From 6736701e5cc40af71535322358f0ff686edf44dc Mon Sep 17 00:00:00 2001 From: Eli Barzilay Date: Sat, 3 Aug 2013 02:22:24 -0400 Subject: [PATCH] Revised installer tests. * The first change is probably due to a difference in my $LANG, so it might be better to set it to a known value for testing. * The second change in an explanation about a corner case in the installer that would be nice to fix, if it's still done in a similar way. --- .../meta/build/unix-installer/test-installer | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/pkgs/plt-services/meta/build/unix-installer/test-installer b/pkgs/plt-services/meta/build/unix-installer/test-installer index 74ff1ab226..2b77042226 100755 --- a/pkgs/plt-services/meta/build/unix-installer/test-installer +++ b/pkgs/plt-services/meta/build/unix-installer/test-installer @@ -134,7 +134,7 @@ exec racket "$0" "$@" Checking the integrity of the binary archive... ok. "@|testdir|/racket@N" exists, delete? @i{y} Deleting old "@|testdir|/racket@N"... @; - /bin/rm: cannot remove `@|testdir|/racket@N': @; + /usr/bin/rm: cannot remove ‘@|testdir|/racket@|N|’: @; Permission denied Error: could not delete "@|testdir|/racket@N". sh> @i{chmod 755 racket*} @@ -199,6 +199,14 @@ exec racket "$0" "$@" Checking the integrity of the binary archive... ok. Unpacking into "@|testdir|/R1" (Ctrl+C to abort)... @break + @; HACK! BAD TEST! + @; This test fails sometimes, when `tar' happens to be the first to break, + @; leading to an unpacking error followed by the file cleanup followed by + @; the "aborting" errors and no cleanup (since it's already done). The + @; test can be modified to try either pattern but it'd be better to find + @; a way to make the output more predictable -- somehow kill the tar + @; process before it errors, and more generally, make it kill any child + @; processes. Error: Aborting... (Removing installation files in @|testdir|/R1) sh> @i{LS}