suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't drop expressions with side effects in eq? reduction

Browse Source 
The expression (eq? x y) is reduced to #f when the types of
x and y are known. Reduce this to (begin x y #f) when they
have side effects.
This commit is contained in:
Gustavo Massaccesi 2015-12-14 17:46:44 -03:00
parent b84233bca7
commit 6985150e0b
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkgs/racket-test-core/tests/racket/optimize.rktl
View File

@ -1494,6 +1494,12 @@
'(lambda (x y) (car x) (unbox y) (eq? x y)))
(test-comp '(lambda (x) (car x) #f)
'(lambda (x) (car x) (eq? x (box 0))))
(test-comp '(lambda (x) (car x) #f)
'(lambda (x) (car x) (eq? (begin (newline) x) (box 0)))
#f)
(test-comp '(lambda (x) (car x) #f)
'(lambda (x) (car x) (eq? x (begin (newline) (box 0))))
#f)
(test-comp '(lambda (w) (car w) (mcar w))
'(lambda (w) (car w) (mcar w) (random)))

8
racket/src/racket/src/optimize.c
View File

@ -3698,7 +3698,13 @@ static Scheme_Object *finish_optimize_application3(Scheme_App3_Rec *app, Optimiz
if (!SAME_OBJ(pred1, pred2)) {
info->preserves_marks = 1;
info->single_result = 1;
return scheme_false;
return do_make_discarding_sequence(app->rand1,
do_make_discarding_sequence(app->rand2,
scheme_false,
info, 0,
1, 0),
info, 0,
1, 0);
}
}
}