suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid integer overflow

Browse Source 
A runtime error was detecting and overflow on e which this fixes.
Fixes part of #2314.
This commit is contained in:
Paulo Matos 2018-10-17 15:47:41 +02:00 committed by Matthew Flatt
parent eb6705be3c
commit 703deedb66
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
racket/src/racket/src/numstr.c
View File

@ -445,7 +445,10 @@ static double STRTOD(const char *orig_c, char **f)
if (!isdigit(ch)) if (!isdigit(ch))
return 0; /* not a digit - bad! */ return 0; /* not a digit - bad! */
else { else {
e = (e * 10) + (ch - '0'); /* only increment e until we know if it is
infinity or zero to avoid overflow on e */
if (!is_zero && !is_infinity)
e = (e * 10) + (ch - '0');
if (e > CHECK_INF_EXP_THRESHOLD(0)) { if (e > CHECK_INF_EXP_THRESHOLD(0)) {
if (neg_exp || !is_nonzero) if (neg_exp || !is_nonzero)
is_zero = 1; is_zero = 1;