suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor TR define to avoid a performance bug

Browse Source 
After commit 3d177e454e
running the main `math.scrbl` file would show peak memory
usage of around 600-700MB when before it was around 400MB.

The proximal cause appears to be the expansion of TR
definitions, which added an extra `begin` in some cases,
combined with redefinitions at the top-level. I don't
know the core cause yet.

Thanks to Matthew for pointing out the issue and to
Vincent for helping with debugging.
This commit is contained in:
Asumu Takikawa 2014-03-31 17:46:39 -04:00
parent 6722b7a71e
commit 92b0e86ed1
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/base-env/prims.rkt
View File

@ -1218,15 +1218,18 @@ This file defines two sorts of primitives. All of them are provided into any mod
(define-syntax (-define stx) (define-syntax (-define stx)
(syntax-parse stx #:literals (:) (syntax-parse stx #:literals (:)
;; the first two cases are actually subsumed by the last, ;; the first three cases are actually subsumed by the last,
;; but manually expanding to using the : annotation form ;; but manually expanding to using the : annotation form
;; produces better error messages on duplicate annotations ;; produces better error messages on duplicate annotations
;;
;; note, these first two cases can be collapsed into one
;; but we keep them separate because in some cases it ruins
;; typechecking performance to merge them.
[(-define nm:id body)
(syntax/loc stx (define nm body))]
[(-define nm:id return:return-ann body) [(-define nm:id return:return-ann body)
(define/with-syntax maybe-ann (quasisyntax/loc stx
(if (attribute return.type) (begin (: nm #,(attribute return.type)) (define nm body)))]
#'(: nm return.type)
#'(void)))
(syntax/loc stx (begin maybe-ann (define nm body)))]
[(-define vars:lambda-type-vars nm:id : ty body) [(-define vars:lambda-type-vars nm:id : ty body)
(define/with-syntax type (define/with-syntax type
(syntax/loc #'ty (All vars.type-vars ty))) (syntax/loc #'ty (All vars.type-vars ty)))