suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix performance bug in late-neg projection for cons/c

Browse Source 
the first-order check and the projection itself
can duplicate work (potentailly lots of work
in a non-constant factor sort of a way when
recursive-contract is involved)

this seems also to be a potential problem for other
uses of or/c too
This commit is contained in:
Robby Findler 2015-12-21 22:45:58 -06:00
parent 99d7ad56d9
commit aeb0509f3a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
racket/collects/racket/contract/private/orc.rkt
View File

@ -74,15 +74,13 @@
(define (single-or/c-late-neg-projection ctc)
(define c-proj (get/build-late-neg-projection (single-or/c-ho-ctc ctc)))
(define c-first-order (contract-first-order (single-or/c-ho-ctc ctc)))
(define pred (single-or/c-pred ctc))
(λ (blame)
(define p-app (c-proj (blame-add-or-context blame)))
(λ (val neg-party)
(cond
[(pred val) val]
[(c-first-order val) (p-app val neg-party)]
[else (raise-none-or-matched blame val neg-party)]))))
[else (p-app val neg-party)]))))
(define (blame-add-or-context blame)
(blame-add-context blame "a part of the or/c of"))