From af63b73bad15610f3d3773bfa0a8544184c454ff Mon Sep 17 00:00:00 2001
From: Paulo Matos <pmatos@linki.tools>
Date: Thu, 6 Jun 2019 08:56:50 +0200
Subject: [PATCH] Update shift left that might cause ub

A few shift lefts cause ub because of `(1 << n)` where `n` is 31.
The constant 1 is signed causing ub. Initially my fix was to do `(1U << n)` however, I have seen the pattern `((U32)1 << n)` elsewhere in the file so decided to follow this.

Caught by ubsan racketcs.
original commit: a902c9ab67010f521f786e2027d4e197d78975a4
---
 c/number.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/c/number.c b/c/number.c
index d0b3512a1d..40578d771d 100644
--- a/c/number.c
+++ b/c/number.c
@@ -1671,7 +1671,7 @@ static ptr big_logbitp(n, x, xl, xs) ptr x; iptr n, xl; IBOOL xs; {
     if (i < 0) return Sfalse;
 
     n = n % bigit_bits;
-    return Sboolean(BIGIT(x,i) & (1 << n));
+    return Sboolean(BIGIT(x,i) & ((U32)1 << n));
   } else {
     bigit xb;
 
@@ -1681,7 +1681,7 @@ static ptr big_logbitp(n, x, xl, xs) ptr x; iptr n, xl; IBOOL xs; {
     xp = &BIGIT(x,xl); xb = 1;
     for (i = xl; ; i -= 1) {
       bigit t1 = *--xp, t2 = t1 - xb;
-      if (n < bigit_bits) return Sboolean(~t2 & (1 << n));
+      if (n < bigit_bits) return Sboolean(~t2 & ((U32)1 << n));
       xb = t2 > t1;
       n -= bigit_bits;
     }
@@ -1804,7 +1804,7 @@ static ptr big_logbit1(tc, origx, n, x, xl, xs) ptr tc, origx, x; iptr n, xl; IB
       *--zp = x1;
       n -= bigit_bits;
     }
-    *--zp = x1 | (1 << n);
+    *--zp = x1 | ((U32)1 << n);
     for (; i > 0; i -= 1) *--zp = *--xp;
     return copy_normalize(zp, zl, 0);
   } else if (yl > xl) {