Add comment to CI step (non-functional)
@samth requested a clarification of the condition under #2959 Hopefully this comment makes it clear that we require the condition in order not to tarball and upload the clang artifact on Linux. The choice not to test both the gcc and clang builds was made to save time and because we are not testing the compiler itself, but racket. Hopefully by the time we get these production compilers, they are generating correct code.
This commit is contained in:
parent
58f51f15ed
commit
b14b2400fd
4
.github/workflows/ci-push.yml
vendored
4
.github/workflows/ci-push.yml
vendored
|
@ -126,6 +126,10 @@ jobs:
|
|||
- name: Installing
|
||||
working-directory: ./racket/src
|
||||
run: make -j $((cpus+1)) install
|
||||
# We build on Linux with clang and gcc and on MacOS with clang only.
|
||||
# However, it makes little sense to test both builds on Linux so we tarball the
|
||||
# gcc build only. Therefore this condition ensure we only perform the tarball
|
||||
# and artifact upload on MacOS or (on Linux) if we are building with gcc.
|
||||
- name: Tarballing
|
||||
if: matrix.cc == 'gcc' || matrix.os == 'macos-latest'
|
||||
working-directory: ../
|
||||
|
|
Loading…
Reference in New Issue
Block a user