suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix ordering issue in typechecking inner calls

Browse Source 
Closes PR 14810
This commit is contained in:
Asumu Takikawa 2014-10-30 03:19:58 -04:00
parent 7829776f72
commit b7eeaf7608
2 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/check-class-unit.rkt
View File

@ -738,8 +738,8 @@
(make-method-types (hash-ref parse-info 'augment-internals) augments))
(define inner-types
(make-method-types
(set-union (hash-ref parse-info 'pubment-internals)
(hash-ref parse-info 'augment-internals))
(append (hash-ref parse-info 'pubment-internals)
(hash-ref parse-info 'augment-internals))
augments #:inner? #t))
;; construct field accessor types

24
pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/class-tests.rkt
View File

@ -1550,4 +1550,26 @@
(super-new)
(define/public (foo [i #f]) (void))))
(new a%))
(-object #:method ([foo (cl->* (t:-> -Void) (t:-> -Integer -Void))]))]))
(-object #:method ([foo (cl->* (t:-> -Void) (t:-> -Integer -Void))]))]
;; PR 14810 - make sure inner type mapping has the right order
[tc-e (let ()
(define-type-alias Foo%
(Class [m (-> Any Symbol)]
[o (-> Any Any Symbol)]
(augment [m (-> Any Symbol)]
[o (-> Any Any Symbol)])))
(define-type-alias Bar% (Class #:implements Foo%))
(: foo% Foo%)
(define foo%
(class object%
(super-new)
(define/pubment (m x) 'foo-m)
(define/pubment (o x y) 'foo-o)))
(: bar% Bar%)
(define bar%
(class foo%
(super-new)
(define/augment (m x) (inner 'bar-m m x))
(define/augment (o x y) (inner 'bar-o o x y))))
(void))
-Void]))