suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Plot for new undefined behavior: #<undefined> is not a truth value

Browse Source 
This is a nice example of why having #<undefined> as a language value is
generally a bad idea. Because in Scheme/Racket, everything that isn't
`refresh?` argument entirely - it was as if its value was always #t. Any
GUI change that was not meant to cause a refresh caused one anyway: a
silent performance error.
This commit is contained in:
Neil Toronto 2014-04-24 10:11:43 -06:00
parent d30546cb7d
commit bee344f41d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkgs/plot-pkgs/plot-gui-lib/plot/private/gui/snip.rkt
View File

@ -56,10 +56,10 @@
(send message-timer start message-timeout #t))
(define/public (set-message msg #:refresh? [refresh? #t])
(define refresh? (and refresh? (not (equal? msg message))))
(set! message msg)
(reset-message-timeout)
(when refresh? (refresh)))
(let ([refresh? (and refresh? (not (equal? msg message)))])
(set! message msg)
(reset-message-timeout)
(when refresh? (refresh))))
(define (draw-message dc dc-x-min dc-y-min)
(define bm (get-bitmap))