suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

when a directory URL fails, suggest a ".git" extension

Browse Source
This commit is contained in:
Matthew Flatt 2015-05-16 16:07:51 -06:00
parent aaef69f40a
commit c4401313d4
1 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
racket/collects/pkg/private/stage.rkt
View File

@ -403,9 +403,17 @@
(url-like "MANIFEST") (url-like "MANIFEST")
port->lines)) port->lines))
(unless manifest (unless manifest
(define suggest-git (suggested-git-path pkg-url given-type))
(pkg-error (~a "could not find MANIFEST for package source\n" (pkg-error (~a "could not find MANIFEST for package source\n"
" source: ~a") " source: ~a~a")
pkg)) pkg
(if suggest-git
(~a "\n"
" possible solution:\n"
" If the URL is intended to refer to a Git repository, use\n"
" " suggest-git "\n"
" so that the URL ends in \".git\"")
"")))
(for ([f (in-list manifest)]) (for ([f (in-list manifest)])
(download-file! (url-like f) (download-file! (url-like f)
(path-like f) (path-like f)
@ -847,3 +855,26 @@
(file->bytes share-file))) (file->bytes share-file)))
;; This file would be redundant, so drop it ;; This file would be redundant, so drop it
(delete-file pkg-file))))) (delete-file pkg-file)))))
;; ----------------------------------------
(define (suggested-git-path pkg-url given-type)
(define p (url-path pkg-url))
(define drop-n
(if (and ((length p) . >= . 1)
(equal? "" (path/param-path (last p))))
2
1))
(and (not given-type)
((length p) . >= . drop-n)
(let ([e (list-ref p (- (length p) drop-n))])
(url->string
(struct-copy url pkg-url [path (append
(drop-right p drop-n)
(list
(path/param
(string-append
(path/param-path e)
".git")
(path/param-param e))))])))))