From c8ecb5e5fe3d4204eb9c7c3419a4dd07523f3f91 Mon Sep 17 00:00:00 2001
From: Matthew Flatt <mflatt@racket-lang.org>
Date: Sat, 9 Sep 2017 05:57:40 -0600
Subject: [PATCH] fix URL parsing in search-in-context browser trampoline

Use the `URL` class in JavaScript instead of manually parsing a URL
string.

Related to #1798
---
 .../main/private/search-context.html          | 23 ++++++++-----------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/pkgs/racket-index/scribblings/main/private/search-context.html b/pkgs/racket-index/scribblings/main/private/search-context.html
index 0e19c8f862..7e7057b1b0 100644
--- a/pkgs/racket-index/scribblings/main/private/search-context.html
+++ b/pkgs/racket-index/scribblings/main/private/search-context.html
@@ -16,23 +16,20 @@
 <script>
 
 if (location.search.length > 0) {
-  var paramstrs = location.search.substring(1).split(/[;&]/);
-  var newsearch = null;
-  for (var i=0; i<paramstrs.length; i++) {
-    var param = paramstrs[i].split(/=/);
+  var u = new URL(location);
+  var newsearch = "";
+  for(var key of u.searchParams.keys()) {
+    var val = u.searchParams.get(key);
     // an empty "hq=" can be used to clear the cookie
-    if (param[0] == "hq") {
-      SetCookie("PLT_ContextQuery",
-                ((param.length==2) ? unescape(param[1]) : ""));
-    } else if (param[0] == "label") {
-      SetCookie("PLT_ContextQueryLabel",
-                ((param.length==2) ? unescape(param[1]) : ""));
+    if (key == "hq") {
+      SetCookie("PLT_ContextQuery", val);
+    } else if (key == "label") {
+      SetCookie("PLT_ContextQueryLabel", val);
     } else {
-      newsearch = (newsearch == null)
-                    ? paramstrs[i] : (newsearch + "&" + paramstrs[i]);
+      if (newsearch == "") newsearch = "?";
+      newsearch = newsearch + "&" + key + "=" + encodeURIComponent(val);
     }
   }
-  newsearch = (newsearch == null) ? "" : ("?" + newsearch);
   // localtion.replace => jump without leaving the current page in the history
   // (the new url uses "index.html" and the new search part)
   location.replace(location.href.replace(/\/[^\/?#]*[?][^#]*/,