diff --git a/collects/unstable/find.ss b/collects/unstable/find.ss index 51d0a93f70..3fc197e7e3 100644 --- a/collects/unstable/find.ss +++ b/collects/unstable/find.ss @@ -54,7 +54,10 @@ (for/fold ([acc acc]) ([elem (in-list xs)]) (loop elem acc))) (reverse (loop x null))) - +;; Eli: This looks borderline too generic to be useful, also in the fact that +;; the documentation tends to explain things in terms of the implementation +;; (eg, the description of #:stop). In any case, you should definitely +;; rename it -- `find' is too common in different ways (see srfi-1 or cltl). (define (find-first pred x #:stop [stop #f] @@ -67,3 +70,4 @@ (if (procedure? default) (default) default))) +;; Eli: Note that this is documented "Like `find-first'". diff --git a/collects/unstable/struct.ss b/collects/unstable/struct.ss index 2ebce5989c..dde3f1fc4a 100644 --- a/collects/unstable/struct.ss +++ b/collects/unstable/struct.ss @@ -81,3 +81,6 @@ ;; fully transparent and wants all of the fields. #:false-on-opaque? ;; also lets this act as a predicate-plus (like member, assoc, etc) ;; for fully-transparent structs. + +;; Eli: Your change to `#:on-opaque' looks good enough to me (and leaves room +;; for extension if needed). (BTW, the contract still has `?'.) diff --git a/collects/unstable/syntax.ss b/collects/unstable/syntax.ss index f0ff099b23..001b24168b 100644 --- a/collects/unstable/syntax.ss +++ b/collects/unstable/syntax.ss @@ -139,6 +139,8 @@ (define (convert x) (->atom x 'id-append)) (define sym (string->symbol (apply string-append (map convert args)))) (datum->syntax lctx sym src props cert)) +;; Eli: Yes, that looks nice (with the same comments as above on the keyword +;; args). It makes more sense with the restriction on the format string. |# (define (restricted-format-string? fmt)