From df07151cb925ccbc61b68021bc47b4eda9614b0b Mon Sep 17 00:00:00 2001
From: Eric Dobson <eric.n.dobson@gmail.com>
Date: Sat, 25 May 2013 15:51:23 -0700
Subject: [PATCH] Centralize the definition of the plambda syntax property.

---
 collects/typed-racket/base-env/prims.rkt         | 16 +++++++---------
 .../typed-racket/private/syntax-properties.rkt   | 11 +++++++++++
 .../typed-racket/typecheck/tc-lambda-unit.rkt    |  4 ++--
 3 files changed, 20 insertions(+), 11 deletions(-)
 create mode 100644 collects/typed-racket/private/syntax-properties.rkt

diff --git a/collects/typed-racket/base-env/prims.rkt b/collects/typed-racket/base-env/prims.rkt
index 0624bcdbb8..f1f6ff8cea 100644
--- a/collects/typed-racket/base-env/prims.rkt
+++ b/collects/typed-racket/base-env/prims.rkt
@@ -57,6 +57,7 @@ This file defines two sorts of primitives. All of them are provided into any mod
           "annotate-classes.rkt"
           "internal.rkt"
           "../utils/tc-utils.rkt"
+          "../private/syntax-properties.rkt"
           "../types/utils.rkt"
           "for-clauses.rkt")
          "../types/numeric-predicates.rkt"
@@ -318,9 +319,8 @@ This file defines two sorts of primitives. All of them are provided into any mod
                  "duplicate type variable declaration"
      (quasisyntax/loc stx
        (#%expression
-        #,(syntax-property (syntax/loc stx (lambda: formals . body))
-                           'typechecker:plambda
-                           #'(tvars ...))))]))
+        #,(plambda-property (syntax/loc stx (lambda: formals . body))
+                            #'(tvars ...))))]))
 
 (define-syntax (pcase-lambda: stx)
   (syntax-parse stx
@@ -329,9 +329,8 @@ This file defines two sorts of primitives. All of them are provided into any mod
                  "duplicate type variable declaration"
      (quasisyntax/loc stx
        (#%expression
-        #,(syntax-property (syntax/loc stx (case-lambda: cl ...))
-                           'typechecker:plambda
-                           #'(tvars ...))))]))
+        #,(plambda-property (syntax/loc stx (case-lambda: cl ...))
+                            #'(tvars ...))))]))
 
 (define-syntax (popt-lambda: stx)
   (syntax-parse stx
@@ -340,9 +339,8 @@ This file defines two sorts of primitives. All of them are provided into any mod
                  "duplicate type variable declaration"
      (quasisyntax/loc stx
        (#%expression
-        #,(syntax-property (syntax/loc stx (opt-lambda: formals . body))
-                           'typechecker:plambda
-                           #'(tvars ...))))]))
+        #,(plambda-property (syntax/loc stx (opt-lambda: formals . body))
+                            #'(tvars ...))))]))
 
 (define-syntax (pdefine: stx)
   (syntax-parse stx #:literals (:)
diff --git a/collects/typed-racket/private/syntax-properties.rkt b/collects/typed-racket/private/syntax-properties.rkt
new file mode 100644
index 0000000000..5f2f21eb7c
--- /dev/null
+++ b/collects/typed-racket/private/syntax-properties.rkt
@@ -0,0 +1,11 @@
+#lang racket/base
+
+(provide plambda-property)
+
+;; TODO: make this an uninterned symbol once the phasing issue of the unit
+;; tests is fixed
+(define plambda-symbol 'typechecker:plambda)
+(define plambda-property
+  (case-lambda
+    ((stx) (syntax-property stx plambda-symbol))
+    ((stx value) (syntax-property stx plambda-symbol value))))
diff --git a/collects/typed-racket/typecheck/tc-lambda-unit.rkt b/collects/typed-racket/typecheck/tc-lambda-unit.rkt
index 3fb5312a3d..0891a4159d 100644
--- a/collects/typed-racket/typecheck/tc-lambda-unit.rkt
+++ b/collects/typed-racket/typecheck/tc-lambda-unit.rkt
@@ -7,7 +7,7 @@
          (except-in (rep type-rep) make-arr)
          (rename-in (except-in (types abbrev utils union) -> ->* one-of/c)
                     [make-arr* make-arr])
-         (private type-annotation)
+         (private type-annotation syntax-properties)
          (typecheck signatures tc-metafunctions tc-subst check-below)
          (env type-env-structs lexical-env tvar-env index-env scoped-tvar-env)
          (utils tc-utils)
@@ -325,7 +325,7 @@
                         expected))))
 
 (define (plambda-prop stx)
-  (define d (syntax-property stx 'typechecker:plambda))
+  (define d (plambda-property stx))
   (and d (car (flatten d))))
 
 (define (has-poly-annotation? form)