thread & io: code clean-ups

Remove unused `require`s and fix some indentation.

racket/src/cs/main.sps

@@ -433,14 +433,14 @@
    (or stderr-logging-arg
        (let ([spec (getenv "PLTSTDERR")])
          (if spec
-             (parse-logging-spec spec "in PLTSTDERR environment variable" #f)
+             (parse-logging-spec "stderr" spec "in PLTSTDERR environment variable" #f)
              '(error)))))
 
  (define stdout-logging
    (or stdout-logging-arg
        (let ([spec (getenv "PLTSTDOUT")])
          (if spec
-             (parse-logging-spec spec "in PLTSTDOUT environment variable" #f)
+             (parse-logging-spec "stdout" spec "in PLTSTDOUT environment variable" #f)
              '()))))
 
  (when (getenv "PLT_STATS_ON_BREAK")

racket/src/io/path/path.rkt

@@ -13,21 +13,21 @@
          ->path)
 
 (struct path (bytes convention)
-        #:property prop:custom-write
+  #:property prop:custom-write
-        (lambda (p port mode)
+  (lambda (p port mode)
-          (when mode
+    (when mode
-            (write-string "#<path:" port))
+      (write-string "#<path:" port))
-          (write-string (bytes->string/locale (path-bytes p)) port)
+    (write-string (bytes->string/locale (path-bytes p)) port)
-          (when mode
+    (when mode
-            (write-string ">" port)))
+      (write-string ">" port)))
-        #:property prop:equal+hash
+  #:property prop:equal+hash
-        (list
+  (list
-         (lambda (p1 p2 eql?)
+   (lambda (p1 p2 eql?)
-           (eql? (path-bytes p1) (path-bytes p2)))
+     (eql? (path-bytes p1) (path-bytes p2)))
-         (lambda (p hc)
+   (lambda (p hc)
-           (hc (path-bytes p)))
+     (hc (path-bytes p)))
-         (lambda (p hc)
+   (lambda (p hc)
-           (hc (path-bytes p)))))
+     (hc (path-bytes p)))))
 
 (define is-path?
   (let ([path? (lambda (p)

racket/src/io/port/bytes-input.rkt

@@ -1,10 +1,8 @@
 #lang racket/base
 (require "../common/check.rkt"
-         "../host/thread.rkt"
          "parameter.rkt"
          "read-and-peek.rkt"
          "input-port.rkt"
-         "count.rkt"
          "progress-evt.rkt"
          "flush-output.rkt")
 

racket/src/io/port/custom-input-port.rkt

@@ -2,11 +2,9 @@
 (require "../common/check.rkt"
          "../host/thread.rkt"
          "input-port.rkt"
-         "output-port.rkt"
          "custom-port.rkt"
          "pipe.rkt"
-         "peek-via-read-port.rkt"
+         "peek-via-read-port.rkt")
-         "buffer-mode.rkt")
 
 (provide make-input-port)
 

racket/src/io/port/string-input.rkt

@@ -3,7 +3,6 @@
          "../host/thread.rkt"
          "parameter.rkt"
          "read-and-peek.rkt"
-         "port.rkt"
          "input-port.rkt"
          (submod "bytes-input.rkt" internal)
          "../string/utf-8-decode.rkt"

racket/src/thread/channel.rkt

@@ -26,20 +26,20 @@
 
 (struct channel (get-queue
                  put-queue)
-        #:property
+  #:property
-        prop:evt
+  prop:evt
-        (poller (lambda (ch poll-ctx)
+  (poller (lambda (ch poll-ctx)
-                  (channel-get/poll ch poll-ctx))))
+            (channel-get/poll ch poll-ctx))))
 
 (struct channel-put-evt* (ch v)
-        #:property
+  #:property
-        prop:evt
+  prop:evt
-        (poller (lambda (cp poll-ctx)
+  (poller (lambda (cp poll-ctx)
-                  (channel-put/poll (channel-put-evt*-ch cp)
+            (channel-put/poll (channel-put-evt*-ch cp)
-                                    (channel-put-evt*-v cp)
+                              (channel-put-evt*-v cp)
-                                    cp
+                              cp
-                                    poll-ctx)))
+                              poll-ctx)))
-        #:reflection-name 'channel-put-evt)
+  #:reflection-name 'channel-put-evt)
 
 ;; A channel must not match get and put from the same thread, which is
 ;; a danger when `sync` queues up multiple events at a time:
@@ -209,6 +209,7 @@
 (define (set-sync-on-channel! sync)
   (set! sync-on-channel sync))
 
-;; 
+;; ----------------------------------------
+
 (define-values (impersonator-prop:channel-put channel-put-impersonator? channel-put-impersonator-ref)
   (make-impersonator-property 'channel-put-impersonator))

racket/src/thread/evt.rkt

@@ -1,6 +1,5 @@
 #lang racket/base
-(require racket/unsafe/ops
+(require "atomic.rkt")
-         "atomic.rkt")
 
 (provide prop:evt
          evt?

racket/src/thread/plumber.rkt

@@ -11,7 +11,7 @@
 
 (struct plumber (callbacks ; hash table of handles -> callbacks
                  weak-callbacks) ; same, but weak references
-  #:property prop:authentic #t)
+  #:authentic)
 
 (define (make-plumber)
   (plumber (make-hasheq)

racket/src/thread/semaphore.rkt

@@ -24,19 +24,19 @@
 
 (struct semaphore ([count #:mutable]
                    queue)
-        #:property
+  #:property
-        prop:evt
+  prop:evt
-        (poller (lambda (s poll-ctx)
+  (poller (lambda (s poll-ctx)
-                  (semaphore-wait/poll s poll-ctx))))
+            (semaphore-wait/poll s poll-ctx))))
 
 (struct semaphore-peek-evt (sema)
-        #:property
+  #:property
-        prop:evt
+  prop:evt
-        (poller (lambda (sp poll-ctx)
+  (poller (lambda (sp poll-ctx)
-                  (semaphore-wait/poll (semaphore-peek-evt-sema sp)
+            (semaphore-wait/poll (semaphore-peek-evt-sema sp)
-                                       poll-ctx
+                                 poll-ctx
-                                       #:peek? #t
+                                 #:peek? #t
-                                       #:result sp))))
+                                 #:result sp))))
 
 (struct semaphore-peek-select-waiter select-waiter ())
 

racket/src/thread/sync.rkt

@@ -8,7 +8,6 @@
          (submod "channel.rkt" for-sync)
          "thread.rkt"
          (only-in (submod "thread.rkt" scheduling)
-                  current-break-enabled-cell
                   thread-descheduled?)
          "schedule-info.rkt")
 

racket/src/thread/system-idle-evt.rkt

@@ -1,7 +1,6 @@
 #lang racket/base
 (require "evt.rkt"
-         "semaphore.rkt"
+         "semaphore.rkt")
-         "internal-error.rkt")
 
 (provide (rename-out [get-system-idle-evt system-idle-evt])
 

racket/src/thread/thread-group.rkt

@@ -1,6 +1,5 @@
 #lang racket/base
-(require "engine.rkt"
+(require "check.rkt"
-         "check.rkt"
          "internal-error.rkt"
          "atomic.rkt")
 

racket/src/thread/thread.rkt

@@ -117,12 +117,12 @@
                      [cpu-time #:mutable] ; accumulates CPU time in milliseconds
                      
                      [condition-wakeup #:mutable])
-        #:property prop:waiter
+  #:property prop:waiter
-        (make-waiter-methods 
+  (make-waiter-methods 
-         #:suspend! (lambda (t i-cb r-cb) (thread-deschedule! t #f i-cb r-cb))
+   #:suspend! (lambda (t i-cb r-cb) (thread-deschedule! t #f i-cb r-cb))
-         #:resume! (lambda (t v) (thread-reschedule! t) v))
+   #:resume! (lambda (t v) (thread-reschedule! t) v))
-        #:property prop:evt (lambda (t) (wrap-evt (get-thread-dead-evt t)
+  #:property prop:evt (lambda (t) (wrap-evt (get-thread-dead-evt t)
-                                                  (lambda (v) t))))
+                                            (lambda (v) t))))
 
 (define root-thread #f)
 

racket/src/thread/waiter.rkt

@@ -36,7 +36,7 @@
 ;; Used for semaphores and channels to run a "just selected" callback
 ;; when synchronized:
 (struct select-waiter (proc)
-        #:property prop:waiter
+  #:property prop:waiter
-        (make-waiter-methods #:suspend! (lambda args (internal-error "should not suspend a select-waiter"))
+  (make-waiter-methods #:suspend! (lambda args (internal-error "should not suspend a select-waiter"))
-                             #:resume! (lambda (w s)
+                       #:resume! (lambda (w s)
-                                         ((select-waiter-proc w)))))
+                                   ((select-waiter-proc w)))))