From e9a73b701ee8edcf54ee29d0fc01f0e7549df7c8 Mon Sep 17 00:00:00 2001
From: Matthew Flatt <mflatt@racket-lang.org>
Date: Thu, 21 Sep 2006 02:39:00 +0000
Subject: [PATCH] explicitly check pregexp arguments, insteda of letting regexp
 errors through

svn: r4404
---
 collects/mzlib/pregexp.ss | 83 +++++++++++++++++++++++++++++++++++----
 1 file changed, 76 insertions(+), 7 deletions(-)

diff --git a/collects/mzlib/pregexp.ss b/collects/mzlib/pregexp.ss
index 4ef4e881b3..ebead20279 100644
--- a/collects/mzlib/pregexp.ss
+++ b/collects/mzlib/pregexp.ss
@@ -17,23 +17,92 @@
 	   pregexp-replace*
 	   (rename regexp-quote pregexp-quote))
 
-  (define (pattern->pregexp pattern)
+  ;; Most of this code just checks arguments, so that errors are reported as
+  ;;  from `pregexp...' instead of `regexp...'. We need a better way to
+  ;;  do that than just writing the checks again.
+
+  (define (pattern->pregexp who pattern)
     (cond
      [(bytes? pattern) (byte-pregexp pattern)]
      [(string? pattern) (pregexp pattern)]
-     [else pattern]))
+     [(regexp? pattern) pattern]
+     [(byte-regexp? pattern) pattern]
+     [else (raise-type-error who "regexp, byte-regexp, string, or byte string"
+			     pattern)]))
+
+  (define (check-input who input)
+    (unless (or (string? input) (bytes? input) (input-port? input))
+      (raise-type-error who "string, byte string, or input port" input)))
+
+  (define (check-start-end-k who input start-k end-k)
+    (unless (and (number? start-k) (exact? start-k) (start-k . >= . 0))
+      (raise-type-error who "exact non-negative integer" start-k))
+    (when end-k
+      (unless (and (number? end-k) (exact? end-k) (end-k . >= . 0))
+	(raise-type-error who "exact non-negative integer or #f" end-k))
+      (unless (start-k . <= . end-k)
+	(raise-mismatch-error who 
+			      (format "starting index ~a is not less than ending index: "
+				      start-k)
+			      end-k)))
+    (let ([len (cond
+		[(bytes? input) (bytes-length bytes)]
+		[(string? input) (string-length input)]
+		[else #f])])
+      (when len
+	(unless (start-k . <= . len)
+	  (raise-mismatch-error who (format "starting index ~a is out of range [0,~a] for input: "
+					    start-k
+					    len)
+				input))
+	(when end-k
+	  (unless (end-k . <= . len)
+	    (raise-mismatch-error who (format "ending index ~a is out of range [~a,~a] for input: "
+					      end-k
+					      start-k
+					      len)
+				  input))))))
+  
+  (define (check-output who output)
+    (when output
+      (unless (or (output-port? output))
+	(raise-type-error who "output port or #f" output))))
+
+  (define (check-insert who input insert)
+    (unless (or (string? insert) (bytes? insert))
+      (raise-type-error who "string or byte string" insert))
+    (when (and (bytes? insert) (string? input))
+      (raise-mismatch-error who "cannot replace a string with a byte string: " insert)))
+
 
   (define/kw (pregexp-match pattern input #:optional [start-k 0] [end-k #f] [output-port #f])
-    (regexp-match (pattern->pregexp pattern) input start-k end-k output-port))
+    (let ([pattern (pattern->pregexp 'pregexp-match pattern)])
+      (check-input 'pregexp-match input)
+      (check-start-end-k 'pregexp-match input start-k end-k)
+      (check-output 'pregexp-match output-port)
+      (regexp-match pattern input start-k end-k output-port)))
 
   (define/kw (pregexp-match-positions pattern input #:optional [start-k 0] [end-k #f] [output-port #f])
-    (regexp-match (pattern->pregexp pattern) input start-k end-k output-port))
+    (let ([pattern (pattern->pregexp 'pregexp-match-positions pattern)])
+      (check-input 'pregexp-match-positions input)
+      (check-start-end-k 'pregexp-match-positions input start-k end-k)
+      (check-output 'pregexp-match-positions output-port)
+      (regexp-match pattern input start-k end-k output-port)))
   
   (define/kw (pregexp-split pattern string #:optional [start 0] [end #f])
-    (regexp-split (pattern->pregexp pattern) string start end))
+    (let ([pattern (pattern->pregexp 'pregexp-split pattern)])
+      (check-input 'pregexp-split string)
+      (check-start-end-k 'pregexp-split string start end)
+      (regexp-split pattern string start end)))
 
   (define/kw (pregexp-replace pattern input insert)
-    (regexp-replace (pattern->pregexp pattern) input insert))
+    (let ([pattern (pattern->pregexp 'regexp-replace pattern)])
+      (check-input 'pregexp-replace input)
+      (check-insert 'pregexp-replace input insert)
+      (regexp-replace pattern input insert)))
 
   (define/kw (pregexp-replace* pattern input insert)
-    (regexp-replace* (pattern->pregexp pattern) input insert)))
+    (let ([pattern (pattern->pregexp 'regexp-replace* pattern)])
+      (check-input 'pregexp-replace* input)
+      (check-insert 'pregexp-replace* input insert)
+      (regexp-replace* pattern input insert))))