From f1dd6be88b6fd52c16814d093f5c5a878400be9f Mon Sep 17 00:00:00 2001 From: Robby Findler Date: Wed, 19 Sep 2012 06:00:26 -0500 Subject: [PATCH] adjust the installer dialog so that it prints a "completed" message at the end of the transcript and so that it shuts down the installation custodian (which means that any threads or anything like that that the .plt file's code may have created will die, plus that the "abort installation" button will now be greyed out) closes PR 13122 --- collects/setup/plt-installer-unit.rkt | 10 ++++++---- doc/release-notes/drracket/HISTORY.txt | 5 +++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/collects/setup/plt-installer-unit.rkt b/collects/setup/plt-installer-unit.rkt index 11116c36b1..e17322fd20 100644 --- a/collects/setup/plt-installer-unit.rkt +++ b/collects/setup/plt-installer-unit.rkt @@ -38,9 +38,9 @@ (stretchable-height #f) (alignment '(center center)))] [kill-button (make-object button% - (string-constant plt-installer-abort-installation) - button-panel - (lambda (b e) (kill)))] + (string-constant plt-installer-abort-installation) + button-panel + (lambda (b e) (kill)))] [done (make-object button% (string-constant close) button-panel (lambda (b e) (done-callback)))] [output (make-output-port #f @@ -102,9 +102,11 @@ (parameterize ([current-eventspace orig-eventspace]) (queue-callback (lambda () + (fprintf output "\nInstallation complete.\n") (set! completed-successfully? #t) ((on-installer-run)) - (cleanup-thunk)))) + (cleanup-thunk) + (custodian-shutdown-all installer-cust)))) (send done enable #t))))))))) diff --git a/doc/release-notes/drracket/HISTORY.txt b/doc/release-notes/drracket/HISTORY.txt index ff2178fc16..f515fdd98a 100644 --- a/doc/release-notes/drracket/HISTORY.txt +++ b/doc/release-notes/drracket/HISTORY.txt @@ -13,6 +13,11 @@ word-wrapping (this avoids some performance problems when very large values are rendered there) + . Adjust the Install .plt File dialog so that it cleans up after the + end of an installation (specifically, it shuts down the custodian + that was running the installation process), which also causes the + Abort button to be disabled. + ------------------------------ Version 5.3 ------------------------------