suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

adjust inliner to avoid infinite inline

Browse Source 
Fixes optimization for an expression like

 (define (f x)
   (lambda (y)
     (letrec ([recursion (f x)])
       (+ x y))))

by adjusting the inlining hueristic to support less inlining on a
second pass of `letrec` right-hand sides.

Closes #3027
This commit is contained in:
Matthew Flatt 2020-01-30 08:31:04 -07:00
parent e0d4ede953
commit fa6e7101df
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkgs/racket-test-core/tests/racket/optimize.rktl
View File

@ -6583,4 +6583,12 @@
;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(module regression-test-to-make-sure-inlining-does-not-go-crazy racket/base
(define (f x)
(lambda (y)
(letrec ([recursion (f x)])
(+ x y)))))
;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(report-errs)

3
racket/src/racket/src/optimize.c
View File

@ -8096,6 +8096,8 @@ static Scheme_Object *optimize_lets(Scheme_Object *form, Optimize_Info *info, in
avoid the possibility of N^2 behavior. */
if (!OPT_DISCOURAGE_EARLY_INLINE)
rhs_info->letrec_not_twice++;
inline_fuel = rhs_info->inline_fuel;
rhs_info->inline_fuel >>= 1;
use_psize = rhs_info->use_psize;
rhs_info->use_psize = info->use_psize;
@ -8111,6 +8113,7 @@ static Scheme_Object *optimize_lets(Scheme_Object *form, Optimize_Info *info, in
if (!OPT_DISCOURAGE_EARLY_INLINE)
--rhs_info->letrec_not_twice;
rhs_info->inline_fuel = inline_fuel;
rhs_info->use_psize = use_psize;
irlv->value = value;