suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use spin loop instead of Sleep for more robust race condition mitigation

Browse Source 
original commit: fb9f854d449ee96cccb63a12629a729046f0bee1
This commit is contained in:
Bob Burger 2018-02-21 16:39:26 -05:00
parent 6b1259cfef
commit fb9d36e050
2 changed files with 27 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
c/windows.c
View File

@ -408,14 +408,20 @@ int S_windows_rename(const char *oldpathname, const char *newpathname) {
int S_windows_rmdir(const char *pathname) {
wchar_t wpathname[PATH_MAX];
int rc;
if (MultiByteToWideChar(CP_UTF8,0,pathname,-1,wpathname,PATH_MAX) == 0)
rc =_rmdir(pathname);
else
rc = _wrmdir(wpathname);
if (0 == rc)
Sleep(0); // Give Windows time to delete the directory.
return rc;
return _rmdir(pathname);
else {
int rc;
if (!(rc = _wrmdir(wpathname))) {
// Spin loop until Windows deletes the directory.
int n;
for (n = 100; n > 0; n--) {
if (_wrmdir(wpathname) && (errno == ENOENT)) break;
}
return 0;
}
return rc;
}
}
int S_windows_stat64(const char *pathname, struct STATBUF *buffer) {
@ -436,14 +442,20 @@ int S_windows_system(const char *command) {
int S_windows_unlink(const char *pathname) {
wchar_t wpathname[PATH_MAX];
int rc;
if (MultiByteToWideChar(CP_UTF8,0,pathname,-1,wpathname,PATH_MAX) == 0)
rc = _unlink(pathname);
else
rc = _wunlink(wpathname);
if (0 == rc)
Sleep(0); // Give Windows time to delete the file.
return rc;
return _unlink(pathname);
else {
int rc;
if (!(rc = _wunlink(wpathname))) {
// Spin loop until Windows deletes the file.
int n;
for (n = 100; n > 0; n--) {
if (_wunlink(wpathname) && (errno == ENOENT)) break;
}
return 0;
}
return rc;
}
}
char *S_windows_getcwd(char *buffer, int maxlen) {

3
release_notes/release_notes.stex
View File

@ -1546,8 +1546,7 @@ in fasl files does not generally make sense.
In Windows, deleting a file or directory briefly leaves the file or
directory in a state where a subsequent create operation fails with
permission denied. This race condition is now mitigated by a call to
Sleep.
permission denied. This race condition is now mitigated.
[This bug applies to all versions up to 9.5 on Windows 7 and later.]
\subsection{Incorrect handling of offset in