From ffe07718b8cf0663402ae61c55d4ba05ff0e9ae7 Mon Sep 17 00:00:00 2001 From: Robby Findler Date: Tue, 23 May 2017 08:45:54 -0500 Subject: [PATCH] adjust browser-run to include any stderr message into the error dialog box --- pkgs/net-lib/net/sendurl.rkt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/pkgs/net-lib/net/sendurl.rkt b/pkgs/net-lib/net/sendurl.rkt index 7d70586fb1..62641521f3 100644 --- a/pkgs/net-lib/net/sendurl.rkt +++ b/pkgs/net-lib/net/sendurl.rkt @@ -302,9 +302,10 @@ ;; Process helper (define (browser-run #:shell [shell? #f] . args) - (define-values (stdout stdin pid stderr control) + (define stderr (open-output-string)) + (define-values (stdout stdin pid _stderr control) (apply values (apply (if shell? process/ports process*/ports) - (open-output-nowhere) #f (current-error-port) + (open-output-nowhere) #f stderr args))) (close-output-port stdin) ;; this is called from plt-help which will immediately exit when we @@ -314,5 +315,7 @@ (thread (lambda () (control 'wait) (when (eq? 'done-error (control 'status)) - (error 'browser-run "process execute failed: ~e" args))))) + (error 'browser-run "process execute failed: ~e\n~a" + args + (get-output-string stderr)))))) (void))