Commit Graph

5 Commits

Author SHA1 Message Date
Robby Findler
a122ea725d fix a bug in the kill-safe abstraction that is designed to protect
the state that online check syntax uses (indirectly via scribble)
to lookup documentation.

since the kill-safe abstraction moved some computation over to
another thread, the values of various parameters (current-directory
in this case) were not preserved. So when scribble then ended up
resolving a module path with the wrong current directory, this
bad value got cached. Then later, when check syntax tries to figure
out what file to open to jump to it, it got the cached bogus value
(even though current-directory was right when check syntax asked
for the filename).

closes PR 12538
2011-12-15 20:37:15 -06:00
Robby Findler
610efbbe75 brutal changes to check syntax to try to see if they fix the symptom Marijn reports 2011-12-13 04:56:13 -06:00
Robby Findler
843f057024 Revert "adjust the synchronization in check syntax for reading doc results to"
This reverts commit 8f12372b17.
2011-12-13 04:56:13 -06:00
Robby Findler
8f12372b17 adjust the synchronization in check syntax for reading doc results to
cope with the case where the thread has been killed (the nacks are
apparently not triggered on thread death in some cases)

(optimistically) closes PR 12427
2011-12-06 16:13:17 -06:00
Robby Findler
d6f54435b7 adjust the interaction between online check syntax and the documentation
system to guarantee that killing online check syntax doesn't wedge the docs
information lookup process
2011-09-21 22:53:02 -05:00