Commit Graph

8 Commits

Author SHA1 Message Date
Eli Barzilay
0814fd5fb5 Make it possible to use "~" or "~user" in the installer.
I've looked for a while, and it seems that there is no easy way to do
this, not even in bash, and worse with /bin/sh.  So this is kind of
resorting to a simple parsing of the input, and using `eval' if it
starts with a tilde.  Note the hack of not doing that when there is a
space, otherwise the `eval' thing will silently ignore it.

This hack means that it's easy to get into a mess if quotes are used
after a tilde, but that was already the case with the use of `eval' to
handle environment variables.  It's not a real security issue, however,
since we're talking about a user who can just run any command anyway.

Also including a test file for the expansion functionality.  If anyone
wants to improve this code, making the tests pass would reveal the
tricky issues.

[FWIW, I've asked on the #bash channel, and the only serious suggestion
was getting the paths as command-line arguments.  This will, however,
defeat the point of being newbie friendly...]

Closes PR 12893.
2012-07-18 22:25:41 -04:00
Eli Barzilay
08b2d7b595 Lots of little changes and fixes, and an extensive testing script. 2011-10-16 18:53:30 -04:00
Eli Barzilay
3589a70308 Rewrote large parts of the unix installer script.
It's now simpler, shorter, and better.  Some of the text is revised,
accepts environment variables when asked for the path, some additional
fixes in misc places.
2011-10-16 18:53:30 -04:00
Eli Barzilay
f882c01e65 Misc improvements (no functionality changes, yet). 2011-10-16 18:53:30 -04:00
Eli Barzilay
08e70c5e45 Make the default answer for running an older uninstaller "yes".
This makes it behave more like the Windows installer, where the default
is to remove an older installation, which most people want to do anyway.
2011-10-16 18:53:30 -04:00
Eli Barzilay
e9db4df6c3 Clearer question about running an existing uninstaller. 2011-10-10 13:30:04 -04:00
Eli Barzilay
de40798d49 Rename "$WHERE1" -> "$BASE". 2011-10-10 13:30:03 -04:00
Eli Barzilay
2240e54660 Rename "plt-installer-header" -> "installer-header" 2010-05-25 22:09:52 -04:00