From b4bf17611054b627fbf5bdceeff63f5b8a294c88 Mon Sep 17 00:00:00 2001
From: Jay McCarthy <jay.mccarthy@gmail.com>
Date: Wed, 30 Dec 2015 19:06:46 -0500
Subject: [PATCH] comments

---
 remix/data0.rkt        | 34 ++++++++++++++++++++++++----------
 remix/tests/simple.rkt |  6 +++---
 2 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/remix/data0.rkt b/remix/data0.rkt
index aa827c0..c155bdc 100644
--- a/remix/data0.rkt
+++ b/remix/data0.rkt
@@ -35,16 +35,18 @@
   (define-syntax (phase1:static-interface stx)
     (syntax-parse stx
       #:literals (remix:#%brackets)
-      [(_si (remix:#%brackets
-             lhs:interface-member rhs:id
-             (~optional
-              (~seq #:is rhs-dt:id)
-              #:defaults ([rhs-dt #'#f])))
-            ...
-            (~optional
-             (~seq #:extensions
-                   extension ...)
-             #:defaults ([[extension 1] '()])))
+      [(_si 
+        ;; XXX make expandable position
+        (remix:#%brackets
+         lhs:interface-member rhs:id
+         (~optional
+          (~seq #:is rhs-dt:id)
+          #:defaults ([rhs-dt #'#f])))
+        ...
+        (~optional
+         (~seq #:extensions
+               extension ...)
+         #:defaults ([[extension 1] '()])))
        (with-syntax* ([int-name (or (syntax-local-name) 'static-interface)]
                       [(def-rhs ...)
                        (for/list ([lhs (in-list
@@ -246,6 +248,7 @@
            (~optional (~and (~seq #:rep (~var rep (static layout-planner?
                                                           "layout planner"))))
                       #:defaults ([rep #f]))
+           ;; XXX make expandable position
            F:field ...)
          (define parent-v (attribute parent-va))
          (define this-rep-id (attribute rep))
@@ -436,10 +439,15 @@
    [(define (def-transform _ stx)
       (syntax-parse stx
         #:literals (remix:#%brackets remix:def theory)
+        ;; XXX support parameters
         [(remix:def (remix:#%brackets theory thy:id)
+                    ;; XXX support properties
+                    ;; XXX make expandable position
                     v:id ...)
          (syntax/loc stx
            (remix:def (remix:#%brackets phase0:layout thy)
+                      ;; XXX add a property for theories
+                      ;; XXX support defaults
                       v ...))]))]))
 
 (define-syntax model
@@ -452,7 +460,12 @@
       (syntax-parse stx
         #:literals (remix:#%brackets remix:def model)
         [(remix:def (remix:#%brackets model thy:id mod:id)
+                    ;; XXX make expandable position
                     (remix:#%brackets f:id v:expr) ...)
+         ;; XXX support verification of properties
+         ;; XXX support theory parameters
+         ;; XXX check that thy is a theory
+         ;; XXX check that f is complete and apply defaults if not
          (syntax/loc stx
            (remix:def (remix:#%brackets thy mod)
                       (remix:#%app
@@ -463,4 +476,5 @@
          model)
 
 ;; xxx (dynamic-)interface
+;; xxx class
 ;; xxx data
diff --git a/remix/tests/simple.rkt b/remix/tests/simple.rkt
index b3ab20e..b40cab8 100644
--- a/remix/tests/simple.rkt
+++ b/remix/tests/simple.rkt
@@ -512,10 +512,8 @@ def x4
 ;; Theories & Models
 
 ;; A theory is a specification of some values
-;; XXX add parameters
 (def [theory Monoid]
   op id)
-;; XXX specify properties
 (module+ test
   ;; You can write generic functions over a theory. This imposes a
   ;; single constant cost to access the operations (basically, a
@@ -528,7 +526,6 @@ def x4
 (def [model Monoid Monoid-Nat:+]
   [op +]
   [id 0])
-;; XXX verify properties
 
 (def [model Monoid Monoid-Nat:*]
   [op *]
@@ -542,3 +539,6 @@ def x4
   ;; we can imagine it might be inlinable.
   {((Monoid-Nat:+.op) 6 Monoid-Nat:+.id) ≡ Monoid-Nat:+.(op Monoid-Nat:+.id 6)})
 
+;; Interfaces & Class
+
+(def [interface ])