From d10077dbde18b68b1b1b1776fad29c254c8b0d28 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Georges=20Dup=C3=A9ron?= <georges.duperon@gmail.com>
Date: Fri, 4 Dec 2015 22:43:48 +0100
Subject: [PATCH] [make works] Search for TODOs in the makefile, so that they
show up at each compilation. Let's try to fix them from time to time :) .
---
graph/lib/low.rkt | 2 +-
graph/make/make.rkt | 14 +++++++++++---
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/graph/lib/low.rkt b/graph/lib/low.rkt
index dde57a13..bf1b248c 100644
--- a/graph/lib/low.rkt
+++ b/graph/lib/low.rkt
@@ -595,7 +595,7 @@
|#
;; New features (arrows and #:first) special-cased for now
- ;; todo: make these features more general.
+ ;; TODO: make these features more general.
[(_ format:simple-format base:dotted #:first-base first-base)
#:with first (format-id #'first-base (syntax-e #'format) #'first-base)
(let ([first-base-len (identifier-length #'first-base)])
diff --git a/graph/make/make.rkt b/graph/make/make.rkt
index e4caf3bf..e4fcc63a 100644
--- a/graph/make/make.rkt
+++ b/graph/make/make.rkt
@@ -38,7 +38,7 @@
(run! (list (find-executable-path-or-fail "sh")
"-c"
@string-append{
- fond_long_lines=0
+ found_long_lines=0
for i in `find \
\( -path ./lib/doc/bracket -prune -and -false \) \
-or \( -name compiled -prune -and -false \) \
@@ -48,13 +48,21 @@
| awk '{if (length > 80) print NR "\t" length "\t" $0}' \
| sed -e 's/^\([0-9]*\t[0-9]*\t.\{80\}\)\(.*\)$/\1\x1b[0;30;41m\2\x1b[m/'`
if test -n "$x"; then
- fond_long_lines=1
+ found_long_lines=1
printf '\033[1;31m%s:\033[m\n' "$i" && printf "%s\n" "$x"
fi
done
- exit $fond_long_lines
+ exit $found_long_lines
}))
+(run! (list(find-executable-path-or-fail "sh")
+ "-c"
+ @string-append{
+ printf "\033[m"; grep -i TODO --with-filename --color=yes -- `find \
+ \( -path ./lib/doc/bracket -prune -and -false \) \
+ -or \( -name compiled -prune -and -false \) \
+ -or -name '*.rkt'`}))
+
;; TODO: should directly exclude them in find-files-by-extension.
(define excluded-dirs (list "docs/"
"bug/"