suzanne.soy/scribble-enhanced
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

doc: fix undefined tags #2

Closed
bennn wants to merge 1 commits from fix-tags into master
pull from: fix-tags
merge into: suzanne.soy:master
Conversation 4 Commits 1 Files Changed 1 +3 -3
bennn commented 2019-12-17 15:49:45 +00:00 (Migrated from github.com)
Copy Link

use defidform/inline to fix undefined tags
without trying to import from scribble/manual

the links all point somewhere now, but maybe not to the right place

use defidform/inline to fix undefined tags without trying to import from `scribble/manual` the links all point somewhere now, but maybe not to the right place
coveralls commented 2019-12-17 16:08:12 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage decreased (-0.07%) to 69.121% when pulling 6c10e2faf3 on bennn:fix-tags into a9e385f717 on jsmaniac:master.

[![Coverage Status](https://coveralls.io/builds/27663472/badge)](https://coveralls.io/builds/27663472) Coverage decreased (-0.07%) to 69.121% when pulling **6c10e2faf3b89cfec84c0e8be28bbfdb41c89f3c on bennn:fix-tags** into **a9e385f71759ad6421107e577f2a0782c16cef07 on jsmaniac:master**.
SuzanneSoy commented 2019-12-17 19:12:46 +00:00 (Migrated from github.com)
Copy Link

Hm, I think this will make the links point to scribble-enhanced's version, instead of pointing to the "official" scribble/manual version. Thanks for pointing at the broken links anyway, I have snippets of code to easily import links from another module and then place them in the docs without a full-blown (require (for-label scribble/manual)) (which would probably clash with a lot of identifiers).

Hm, I think this will make the links point to scribble-enhanced's version, instead of pointing to the "official" scribble/manual version. Thanks for pointing at the broken links anyway, I have snippets of code to easily import links from another module and then place them in the docs without a full-blown `(require (for-label scribble/manual))` (which would probably clash with a lot of identifiers).
bennn commented 2019-12-17 20:15:38 +00:00 (Migrated from github.com)
Copy Link

Should they all point to scribble?

If so, I can change this PR.

(But maybe its easier to close this & leave it to you)

Should they all point to scribble? If so, I can change this PR. (But maybe its easier to close this & leave it to you)
SuzanneSoy commented 2019-12-17 20:16:51 +00:00 (Migrated from github.com)
Copy Link

Yeah, they should point to scribble. Closing for now :)

Yeah, they should point to scribble. Closing for now :)
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
ready

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
ready
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suzanne.soy/scribble-enhanced#2
No description provided.
Delete Branch "fix-tags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?