suzanne.soy/scribble-math
1
0
Fork 0
Code Issues 8 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Look at WebKit version instead of checking Safari

Browse Source 
Reviewers: emily

Reviewed By: emily

Differential Revision: http://phabricator.khanacademy.org/D3317
This commit is contained in:
Ben Alpert 2013-08-01 17:43:06 -07:00
parent aa4e05a7cf
commit 6883017bc4
2 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
katex.js
View File

@ -86,8 +86,9 @@ var buildGroup = function(style, color, group, prev) {
} else if (group.type === "close") {
return makeSpan("mclose" + color, [textit(group.value)]);
} else if (group.type === "frac") {
if (utils.isSafari) {
throw new ParseError("KaTeX fractions don't work in Safari");
if (utils.isBuggyWebKit) {
throw new ParseError(
"KaTeX fractions don't work in WebKit <= 537.1");
}
var fstyle = style;

32
utils.js
View File

@ -13,17 +13,37 @@ function slowContains(list, elem) {
var contains = Array.prototype.indexOf ? fastContains : slowContains;
function isSafari() {
function isBuggyWebKit() {
var userAgent = navigator.userAgent.toLowerCase();
// Steal these regexes from jQuery migrate for browser detection
var webkit = /(webkit)[ \/]([\w.]+)/.exec(userAgent);
var chrome = /(chrome)[ \/]([\w.]+)/.exec(userAgent);
var webkit = (/applewebkit\/(\d+)\.(\d+)/).exec(userAgent);
if (!webkit) {
return false;
}
return webkit && !chrome;
var major = +webkit[1];
var minor = +webkit[2];
// 537.1 is last buggy, according to Chrome's bisect-builds.py which says:
//
// You are probably looking for a change made after 137695 (known bad), but
// no later than 137702 (first known good).
// CHANGELOG URL:
// http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=137695%3A137702
//
// Downloading these two builds:
// http://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/137695/chrome-mac.zip
// http://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/137702/chrome-mac.zip
// verifies this claim. The respective WebKit versions (r117232 and
// r117456) both are called 537.1 so let's throw out 537.1 as well as
// everything older.
//
// The responsible WebKit changeset appears to be this one:
// http://trac.webkit.org/changeset/117339/
return major < 537 || (major == 537 && minor <= 1);
}
module.exports = {
contains: contains,
isSafari: isSafari()
isBuggyWebKit: isBuggyWebKit()
};