suzanne.soy/scribble-math
1
0
Fork 0
Code Issues 8 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Add --wait option to screenshotter (#510)

Browse Source 
Sometimes a page might not be ready when the screenshot is taken, due to
fonts still being loaded or some such.  In --verify mode this is taken care
of by repeated attempts.  But when creating a screenshot for the first time,
it might be desirable to wait a given number of seconds for things to settle
down.  So this commit introduces a --wait option to the screenshotter.
This commit is contained in:
Martin von Gagern 2016-07-29 21:26:30 +02:00 committed by Kevin Barabash
parent 725524a214
commit 92bbbffbc8
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dockers/Screenshotter/screenshotter.js
View File

@ -69,6 +69,9 @@ var opts = require("nomnom")
flag: true, flag: true,
help: "Check whether screenshot matches current file content", help: "Check whether screenshot matches current file content",
}) })
.option("wait", {
help: "Wait this many seconds between page load and screenshot",
})
.parse(); .parse();
var listOfCases; var listOfCases;
@ -281,6 +284,9 @@ function takeScreenshot(key) {
var url = katexURL + "test/screenshotter/test.html?" + itm.query; var url = katexURL + "test/screenshotter/test.html?" + itm.query;
driver.get(url); driver.get(url);
if (opts.wait) {
browserSideWait(1000 * opts.wait);
}
driver.takeScreenshot().then(haveScreenshot).then(function() { driver.takeScreenshot().then(haveScreenshot).then(function() {
if (--countdown === 0) { if (--countdown === 0) {
if (listOfFailed.length) { if (listOfFailed.length) {