From ccd8f40028237e63236489baebe5fabecf99bcc1 Mon Sep 17 00:00:00 2001 From: Emily Eisenberg Date: Fri, 15 Apr 2016 12:08:14 -0700 Subject: [PATCH] Make `make lint` not automatically fix lint Summary: Looks like there was lint, but `make lint` wasn't failing on it because it would just automatically fix it! This removes the `--fix` from `eslint` and fixes the lint. Test Plan: - `make lint` Auditors: kevinb --- Makefile | 2 +- test/katex-spec.js | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index ecf4ed311..546cbaa15 100644 --- a/Makefile +++ b/Makefile @@ -17,7 +17,7 @@ setup: npm install lint: katex.js server.js cli.js $(wildcard src/*.js) $(wildcard test/*.js) $(wildcard contrib/*/*.js) $(wildcard dockers/*/*.js) - ./node_modules/.bin/eslint --fix $^ + ./node_modules/.bin/eslint $^ build/katex.js: katex.js $(wildcard src/*.js) $(BROWSERIFY) $< --standalone katex > $@ diff --git a/test/katex-spec.js b/test/katex-spec.js index 75a0d393e..4a793b884 100644 --- a/test/katex-spec.js +++ b/test/katex-spec.js @@ -421,12 +421,13 @@ describe("A parser with limit controls", function() { it("should have the rightmost limit control determine the limits property " + "of the preceding op node", function() { - var parsedInput = getParsed("\\int\\nolimits\\limits_2^2"); - expect(parsedInput[0].value.base.value.limits).toBe(true); - parsedInput = getParsed("\\int\\limits_2\\nolimits^2"); - expect(parsedInput[0].value.base.value.limits).toBe(false); - }); + var parsedInput = getParsed("\\int\\nolimits\\limits_2^2"); + expect(parsedInput[0].value.base.value.limits).toBe(true); + + parsedInput = getParsed("\\int\\limits_2\\nolimits^2"); + expect(parsedInput[0].value.base.value.limits).toBe(false); + }); }); describe("A group parser", function() {