From 6bd0af2a06fe40f7aa0e1ab631aecfaaee5a95d3 Mon Sep 17 00:00:00 2001 From: Matthew Brennan Jones Date: Sun, 26 Jul 2015 18:41:26 -0700 Subject: [PATCH 1/3] Updated matching to remove redundant python versions. --- server.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/server.js b/server.js index 1149a12..78f5c85 100644 --- a/server.js +++ b/server.js @@ -1639,6 +1639,15 @@ cache(function(data, match, sendBadge, request) { versions.push(matched[1]); } } + ['2', '3'].forEach(function(version) { + if (versions.some(function(element, index, array) { return new RegExp('^' + version + '\\.\\d$').exec(element); })) { + versions.forEach(function(element, index, array) { + if (element === version) { + array.splice(index, 1); + } + }); + } + }); if (!versions.length) { versions.push('not found'); } From 648da22b5087130610c13f9f3c017a6e20ef9e3f Mon Sep 17 00:00:00 2001 From: Matthew Brennan Jones Date: Sun, 2 Aug 2015 12:22:31 -0700 Subject: [PATCH 2/3] Made spacing style consistent. --- server.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/server.js b/server.js index 78f5c85..440a646 100644 --- a/server.js +++ b/server.js @@ -1640,13 +1640,13 @@ cache(function(data, match, sendBadge, request) { } } ['2', '3'].forEach(function(version) { - if (versions.some(function(element, index, array) { return new RegExp('^' + version + '\\.\\d$').exec(element); })) { - versions.forEach(function(element, index, array) { - if (element === version) { - array.splice(index, 1); - } - }); - } + if (versions.some(function(element, index, array) { return new RegExp('^' + version + '\\.\\d$').exec(element); })) { + versions.forEach(function(element, index, array) { + if (element === version) { + array.splice(index, 1); + } + }); + } }); if (!versions.length) { versions.push('not found'); From 3f73568edca0aa3a25aab209a54d102a0322ca93 Mon Sep 17 00:00:00 2001 From: Matthew Brennan Jones Date: Sun, 2 Aug 2015 12:52:15 -0700 Subject: [PATCH 3/3] Updated to not change original array inside forEach loop. --- server.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server.js b/server.js index 440a646..748417f 100644 --- a/server.js +++ b/server.js @@ -1641,11 +1641,13 @@ cache(function(data, match, sendBadge, request) { } ['2', '3'].forEach(function(version) { if (versions.some(function(element, index, array) { return new RegExp('^' + version + '\\.\\d$').exec(element); })) { + var filteredVersions = []; versions.forEach(function(element, index, array) { - if (element === version) { - array.splice(index, 1); + if (element !== version) { + filteredVersions.push(element); } }); + versions = filteredVersions; } }); if (!versions.length) {