Show 0 downloads for npm packages with no downloads

Fixes #635.
This commit is contained in:
Thaddee Tyl 2016-02-14 18:37:50 +01:00
parent cd47c1e228
commit 35dad91bf9

View File

@ -1352,12 +1352,7 @@ cache(function(data, match, sendBadge, request) {
return; return;
} }
try { try {
var monthly = JSON.parse(buffer).downloads; var monthly = JSON.parse(buffer).downloads || 0;
} catch(e) {
badgeData.text[1] = 'invalid';
sendBadge(format, badgeData);
return;
}
badgeData.text[1] = metric(monthly) + '/month'; badgeData.text[1] = metric(monthly) + '/month';
if (monthly === 0) { if (monthly === 0) {
badgeData.colorscheme = 'red'; badgeData.colorscheme = 'red';
@ -1371,6 +1366,10 @@ cache(function(data, match, sendBadge, request) {
badgeData.colorscheme = 'brightgreen'; badgeData.colorscheme = 'brightgreen';
} }
sendBadge(format, badgeData); sendBadge(format, badgeData);
} catch(e) {
badgeData.text[1] = 'invalid';
sendBadge(format, badgeData);
}
}); });
})); }));
@ -1391,7 +1390,7 @@ cache(function (data, match, sendBadge, request) {
try { try {
var totalDownloads = 0; var totalDownloads = 0;
var downloads = JSON.parse(buffer).downloads; var downloads = JSON.parse(buffer).downloads || 0;
for (var index = 0; index < downloads.length; index++) { for (var index = 0; index < downloads.length; index++) {
totalDownloads = totalDownloads + downloads[index].downloads; totalDownloads = totalDownloads + downloads[index].downloads;
} }