From 648bef473bb5657e5a546b3d97e825000a393fe2 Mon Sep 17 00:00:00 2001 From: Thaddee Tyl Date: Sun, 17 Jan 2016 20:12:34 +0100 Subject: [PATCH] website: clicking on URL now shows the badge dialog Instead of selecting the URL. As suggested by @techtonik https://github.com/badges/shields/issues/530#issuecomment-167277875. --- try.html | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/try.html b/try.html index e2211e7..08a52d5 100644 --- a/try.html +++ b/try.html @@ -44,7 +44,8 @@ hr.spacing { border: 0; display: block; height: 3mm; } border-bottom: 15px solid #eaeaff; } #suggestButton { display: none; } -table.badge > tbody > tr > td > img { cursor: pointer; } +table.badge > tbody > tr > td > img, +table.badge > tbody > tr > td > code { cursor: pointer; }
@@ -1156,14 +1157,6 @@ function selectNode(e) { }; copyMarkdown.addEventListener('click', selectNode); copyreStructuredText.addEventListener('click', selectNode); -function autoselectCode() { - var codes = document.querySelectorAll('table.badge code'); - for (var i = 0; i < codes.length; i++) { - codes[i].addEventListener('click', selectNode); - } -} - -document.addEventListener('DOMContentLoaded', autoselectCode); // Markup copier dialog // @@ -1173,9 +1166,11 @@ function markupDialogInit() { for (var i = 0; i < trs.length; i++) { var tr = trs[i]; var target = tr.querySelector('img'); - if (target) { - target.addEventListener('click', makeMarkupDialogListener(tr)); - } + var code = tr.querySelector('code'); + // Markup dialog listener. + var mdl = makeMarkupDialogListener(tr); + if (target != null) { target.addEventListener('click', mdl); } + if (code != null) { code.addEventListener('click', mdl); } } } function makeMarkupDialogListener(tr) {