suzanne.soy/shields
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Put GitHub user token synchronization in the background

Browse Source 
Issue #529.
This commit is contained in:
Thaddee Tyl 2016-06-01 23:55:17 +02:00
parent c403e367f7
commit fc223c9f86
1 changed files with 33 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
lib/github-auth.js
View File

@ -60,38 +60,11 @@ function setRoutes(server) {
}
console.log('GitHub OAuth: ' + token);
// FIXME: synchronize things in the background.
// Send the token to all of those IPs.
var ips = serverSecrets.shieldsIps;
Promise.all(ips.map(function(ip) {
return new Promise(function(resolve, reject) {
var options = {
url: 'https://' + ip + '/github-auth/add-token',
method: 'POST',
form: {
shieldsSecret: serverSecrets.shieldsSecret,
token: token,
},
// We target servers by IP, and we use HTTPS. Assuming that
// 1. Internet routers aren't hacked, and
// 2. We don't unknowingly lose our IP to someone else,
// we're not leaking people's and our information.
// (If we did, it would have no impact, as we only ask for a token,
// no GitHub scope. The malicious entity would only be able to use
// our rate limit pool.)
// FIXME: use letsencrypt.
strictSSL: false,
};
request(options, function(err, res, body) {
if (err != null) { return reject('Posting the GitHub user token failed: ' + err.stack); }
resolve();
});
});
})).then(function() {
end('Done!');
}).catch(function(e) {
end('Done!');
sendTokenToAllServers(token)
.catch(function(e) {
console.error('GitHub user token transmission failed:', e);
end('Horror! Something went wrong. Please try again.');
});
});
});
@ -110,4 +83,33 @@ function setRoutes(server) {
});
};
function sendTokenToAllServers(token) {
var ips = serverSecrets.shieldsIps;
return Promise.all(ips.map(function(ip) {
return new Promise(function(resolve, reject) {
var options = {
url: 'https://' + ip + '/github-auth/add-token',
method: 'POST',
form: {
shieldsSecret: serverSecrets.shieldsSecret,
token: token,
},
// We target servers by IP, and we use HTTPS. Assuming that
// 1. Internet routers aren't hacked, and
// 2. We don't unknowingly lose our IP to someone else,
// we're not leaking people's and our information.
// (If we did, it would have no impact, as we only ask for a token,
// no GitHub scope. The malicious entity would only be able to use
// our rate limit pool.)
// FIXME: use letsencrypt.
strictSSL: false,
};
request(options, function(err, res, body) {
if (err != null) { return reject('Posting the GitHub user token failed: ' + err.stack); }
resolve();
});
});
}));
}
exports.setRoutes = setRoutes;