From 7758844f96be25e937faa79ef3703b155215d025 Mon Sep 17 00:00:00 2001 From: whitequark Date: Sun, 27 Nov 2016 14:24:20 +0000 Subject: [PATCH] Do not re-solve groups that converge but fail rank test. This partially reverts commit 3a585ea. We no longer need this because the VectorsParallel() is gone, and there is no chance of pivoting wrong when solving. --- src/generate.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/generate.cpp b/src/generate.cpp index 35d88b0..5c466d8 100644 --- a/src/generate.cpp +++ b/src/generate.cpp @@ -489,14 +489,8 @@ void SolveSpaceUI::SolveGroupAndReport(hGroup hg, bool andFindFree) { SolveGroup(hg, andFindFree); Group *g = SK.GetGroup(hg); - if(g->solved.how == SolveResult::REDUNDANT_OKAY) { - // Solve again, in case we lost a degree of freedom because of a numeric error. - SolveGroup(hg, andFindFree); - } - bool isOkay = g->solved.how == SolveResult::OKAY || (g->allowRedundant && g->solved.how == SolveResult::REDUNDANT_OKAY); - if(!isOkay || (isOkay && !g->IsSolvedOkay())) { TextWindow::ReportHowGroupSolved(g->h); }