suzanne.soy/tock-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always infer left-to-right for dyadic operators (except shifts).

Browse Source 
This isn't the right behaviour, although it's closer: what it really needs to
do is to try to infer both sides in the current (or no) context, pick the more
specific type of the two inferred, then use that to redo the other one. Yuck!
This commit is contained in:
Adam Sampson 2008-04-07 12:04:34 +00:00
parent caa59c6788
commit 3326c56a54
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
frontends/OccamTypes.hs
View File

@ -625,7 +625,7 @@ inferTypes = applyExplicitM9 doExpression doDimension doSubscript
-- context.
A.Dyadic m op le re ->
case classifyOp op of
-- Infer the RHS type from the LHS.
-- No info about the LHS; infer the RHS type from the LHS.
ComparisonOp ->
do le' <- noTypeContext $ inferTypes le
t <- typeOfExpression le'
@ -636,8 +636,13 @@ inferTypes = applyExplicitM9 doExpression doDimension doSubscript
do le' <- inferTypes le
re' <- inTypeContext (Just A.Int) $ inferTypes re
return $ A.Dyadic m op le' re'
-- Otherwise it's the type we already have.
_ -> descend outer
-- Otherwise infer the LHS from the current context,
-- then the RHS from that.
_ ->
do le' <- inferTypes le
t <- typeOfExpression le'
re' <- inTypeContext (Just t) $ inferTypes re
return $ A.Dyadic m op le' re'
A.SizeExpr _ _ -> noTypeContext $ descend outer
A.Conversion _ _ _ _ -> noTypeContext $ descend outer
A.FunctionCall m n es ->