suzanne.soy/tock-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added a warning when we removed an unused variable

Browse Source
This commit is contained in:
Neil Brown 2008-11-13 15:37:02 +00:00
parent 0d486f108f
commit 6fc4ac9550
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
checks/Check.hs
View File

@ -278,11 +278,12 @@ checkProcCallArgsUsage = mapM_ checkArgs . listify isProcCall
checkUnusedVar :: CheckOptM ()
checkUnusedVar = forAnyAST doSpec
where
doSpec (A.Spec _ (A.Specification _ name _) scope :: A.Structured A.Process)
doSpec (A.Spec _ (A.Specification mspec name _) scope :: A.Structured A.Process)
= do vars <- withChild [1] $ getCachedAnalysis' isScopeIn varsTouchedAfter
liftIO $ putStrLn $ "Vars: " ++ show vars
when (not $ (Var $ A.Variable emptyMeta name) `Set.member` vars) $
substitute scope
do warnPC mspec WarnUnusedVariable $ formatCode "Unused variable: %" name
substitute scope
doSpec _ = return ()
isScopeIn :: UsageLabel -> Bool

9
checks/CheckFramework.hs
View File

@ -117,6 +117,9 @@ instance Die CheckOptM where
instance CSMR CheckOptM where
getCompState = CheckOptM . lift $ getCompState
instance Warn CheckOptM where
warnReport = CheckOptM . lift . warnReport
deCheckOptM :: CheckOptM a -> StateT CheckOptData PassM a
deCheckOptM (CheckOptM x) = x
@ -154,6 +157,12 @@ instance Die m => Die (ReaderT (Route t outer) m) where
instance Die (CheckOptM' t) where
dieReport = liftCheckOptM . dieReport
instance Warn (CheckOptM' t) where
warnReport = liftCheckOptM . warnReport
instance CSMR (CheckOptM' t) where
getCompState = liftCheckOptM getCompState
askRoute :: CheckOptM' t (Route t A.AST)
askRoute = CheckOptM' . RestartT . liftM Right $ ask