diff --git a/spec/v3/services/builds/find_spec.rb b/spec/v3/services/builds/find_spec.rb index b14ab715..71d6555f 100644 --- a/spec/v3/services/builds/find_spec.rb +++ b/spec/v3/services/builds/find_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' describe Travis::API::V3::Services::Builds::Find do let(:repo) { Repository.by_slug('svenfuchs/minimal').first } - let(:build) { repo.builds.first } + let(:build) { repo.builds.last } let(:parsed_body) { JSON.load(body) } describe "fetching builds on a public repository by slug" do @@ -26,8 +26,27 @@ describe Travis::API::V3::Services::Builds::Find do example { expect(last_response).to be_ok } example { expect(parsed_body).to be == { "@type" => "builds", - "@href" => "/v3/repo/#{repo.id}/builds", - "builds" => { + "@href" => "/v3/repo/#{repo.id}/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" =>1}, + "prev" =>nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ "@type" => "build", "@href" => "/v3/build/#{build.id}", "id" => build.id, @@ -37,6 +56,7 @@ describe Travis::API::V3::Services::Builds::Find do "event_type" => "push", "previous_state" => "passed", "started_at" => "2010-11-12T13:00:00Z", + "finished_at" => nil, "repository" => { "@type" => "repository", "@href" => "/v3/repo/1", @@ -47,7 +67,7 @@ describe Travis::API::V3::Services::Builds::Find do "@href" => "/v3/repo/1/branch/master", "name" => "master", "last_build" => { - "@href"=>"/v3/build/62" }}, + "@href"=>"/v3/build/#{build.id}" }}, "commit" => { "@type" => "commit", "id" => 5, @@ -55,303 +75,303 @@ describe Travis::API::V3::Services::Builds::Find do "ref" => "refs/heads/master", "message" => "unignore Gemfile.lock", "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", - "committed_at" => "2010-11-12T12:55:00Z"}}, + "committed_at" => "2010-11-12T12:55:00Z"}}], }} end -# -# describe "missing repository" do -# before { get("/v3/repo/999999999999999") } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "public repository, private API" do -# before { Travis.config.private_api = true } -# before { get("/v3/repo/#{repo.id}") } -# after { Travis.config.private_api = false } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, not authenticated" do -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}") } -# before { repo.update_attribute(:private, false) } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, private API, authenticated as user with access" do -# let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} -# before { Permission.create(repository: repo, user: repo.owner, pull: true) } -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# after { repo.update_attribute(:private, false) } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to be == { -# "@type" => "repository", -# "@href" => "/v3/repo/#{repo.id}", -# "@permissions" => { -# "read" => true, -# "enable" => false, -# "disable" => false, -# "create_request" => false}, -# "id" => repo.id, -# "name" => "minimal", -# "slug" => "svenfuchs/minimal", -# "description" => nil, -# "github_language" => nil, -# "active" => true, -# "private" => true, -# "owner" => { -# "@type" => "user", -# "@href" => "/v3/user/#{repo.owner_id}", -# "id" => repo.owner_id, -# "login" => "svenfuchs" }, -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build_id}", -# "id" => repo.last_build_id, -# "number" => "2", -# "state" => "passed", -# "duration" => nil, -# "started_at" => "2010-11-12T12:30:00Z", -# "finished_at" => "2010-11-12T12:30:20Z"}, -# "default_branch" => { -# "@type" => "branch", -# "@href" => "/v3/repo/#{repo.id}/branch/master", -# "name" => "master", -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build.id}", -# "id" => repo.last_build.id, -# "number" => "3", -# "state" => "configured", -# "duration" => nil, -# "event_type" => "push", -# "previous_state" => "passed", -# "started_at" => "2010-11-12T13:00:00Z", -# "finished_at" => nil}} -# }} -# end -# -# describe "private repository, private API, authenticated as user without access" do -# let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, authenticated as internal application with full access" do -# let(:app_name) { 'travis-example' } -# let(:app_secret) { '12345678' } -# let(:sign_opts) { "a=#{app_name}" } -# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} -# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} -# -# -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# -# -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to be == { -# "@type" => "repository", -# "@href" => "/v3/repo/#{repo.id}", -# "@permissions" => { -# "read" => true, -# "enable" => true, -# "disable" => true, -# "create_request" => true}, -# "id" => repo.id, -# "name" => "minimal", -# "slug" => "svenfuchs/minimal", -# "description" => nil, -# "github_language" => nil, -# "active" => true, -# "private" => true, -# "owner" => { -# "@type" => "user", -# "@href" => "/v3/user/#{repo.owner_id}", -# "id" => repo.owner_id, -# "login" => "svenfuchs" }, -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build_id}", -# "id" => repo.last_build_id, -# "number" => "2", -# "state" => "passed", -# "duration" => nil, -# "started_at" => "2010-11-12T12:30:00Z", -# "finished_at" => "2010-11-12T12:30:20Z"}, -# "default_branch" => { -# "@type" => "branch", -# "@href" => "/v3/repo/#{repo.id}/branch/master", -# "name" => "master", -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build.id}", -# "id" => repo.last_build.id, -# "number" => "3", -# "state" => "configured", -# "duration" => nil, -# "event_type" => "push", -# "previous_state" => "passed", -# "started_at" => "2010-11-12T13:00:00Z", -# "finished_at" => nil}} -# }} -# end -# -# describe "private repository, authenticated as internal application with full access, but scoped to a different org" do -# let(:app_name) { 'travis-example' } -# let(:app_secret) { '12345678' } -# let(:sign_opts) { "a=#{app_name}:s=travis-pro" } -# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} -# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} -# -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, authenticated as internal application with full access, scoped to the right org" do -# let(:app_name) { 'travis-example' } -# let(:app_secret) { '12345678' } -# let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" } -# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} -# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} -# -# -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# -# -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to be == { -# "@type" => "repository", -# "@href" => "/v3/repo/#{repo.id}", -# "@permissions" => { -# "read" => true, -# "enable" => true, -# "disable" => true, -# "create_request" => true}, -# "id" => repo.id, -# "name" => "minimal", -# "slug" => "svenfuchs/minimal", -# "description" => nil, -# "github_language" => nil, -# "active" => true, -# "private" => true, -# "owner" => { -# "@type" => "user", -# "@href" => "/v3/user/#{repo.owner_id}", -# "id" => repo.owner_id, -# "login" => "svenfuchs" }, -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build_id}", -# "id" => repo.last_build_id, -# "number" => "2", -# "state" => "passed", -# "duration" => nil, -# "started_at" => "2010-11-12T12:30:00Z", -# "finished_at" => "2010-11-12T12:30:20Z"}, -# "default_branch" => { -# "@type" => "branch", -# "@href" => "/v3/repo/#{repo.id}/branch/master", -# "name" => "master", -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build.id}", -# "id" => repo.last_build.id, -# "number" => "3", -# "state" => "configured", -# "duration" => nil, -# "event_type" => "push", -# "previous_state" => "passed", -# "started_at" => "2010-11-12T13:00:00Z", -# "finished_at" => nil}} -# }} -# end -# -# describe "including full owner" do -# before { get("/v3/repo/#{repo.id}?include=repository.owner") } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at", -# "@type" => "user", -# "id" => repo.owner_id, -# "login" => "svenfuchs", -# )} -# end -# -# describe "including full owner and full last build" do -# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build") } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body['last_build']['state']).to be == 'passed' } -# example { expect(parsed_body['last_build']['repository']).to be == { "@href" => "/v3/repo/#{repo.id}" } } -# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at")} -# end -# -# describe "including non-existing field" do -# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build_number") } -# example { expect(last_response.status).to be == 400 } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "wrong_params", -# "error_message" => "no field \"repository.last_build_number\" to include" -# }} -# end -# -# describe "wrong include format" do -# before { get("/v3/repo/#{repo.id}?include=repository.last_build.branch") } -# example { expect(last_response.status).to be == 400 } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "wrong_params", -# "error_message" => "illegal format for include parameter" -# }} -# end -# -# describe "including nested objects" do -# before { get("/v3/repo/#{repo.id}?include=repository.last_build,build.branch") } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to include("last_build") } -# end + + describe "builds on missing repository" do + before { get("/v3/repo/999999999999999/builds") } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on public repository, private API" do + before { Travis.config.private_api = true } + before { get("/v3/repo/#{repo.id}/builds") } + after { Travis.config.private_api = false } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on private repository, not authenticated" do + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds") } + before { repo.update_attribute(:private, false) } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds private repository, private API, authenticated as user with access" do + let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} + before { Permission.create(repository: repo, user: repo.owner, pull: true) } + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } + after { repo.update_attribute(:private, false) } + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "builds", + "@href" => "/v3/repo/1/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" => 1 }, + "prev" => nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ + "@type" => "build", + "@href" => "/v3/build/#{build.id}", + "id" => build.id, + "number" => "3", + "state" => "configured", + "duration" => nil, + "event_type" => "push", + "previous_state" => "passed", + "started_at" => "2010-11-12T13:00:00Z", + "finished_at" =>nil, + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/1", + "id" => 1, + "slug" => "svenfuchs/minimal"}, + "branch" => { + "@type" => "branch", + "@href" => "/v3/repo/1/branch/master", + "name" => "master", + "last_build" => { + "@href" => "/v3/build/#{build.id}"}}, + "commit" => { + "@type" => "commit", + "id" => 5, + "sha" => "add057e66c3e1d59ef1f", + "ref" => "refs/heads/master", + "message" => "unignore Gemfile.lock", + "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", + "committed_at" => "2010-11-12T12:55:00Z"}}] + }} + end + + describe "builds on private repository, private API, authenticated as user without access" do + let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds", {}, headers) } + before { repo.update_attribute(:private, false) } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on private repository, authenticated as internal application with full access" do + let(:app_name) { 'travis-example' } + let(:app_secret) { '12345678' } + let(:sign_opts) { "a=#{app_name}" } + let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} + before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} + + + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } + before { repo.update_attribute(:private, false) } + + + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "builds", + "@href" => "/v3/repo/1/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" => 1 }, + "prev" => nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ + "@type" => "build", + "@href" => "/v3/build/#{build.id}", + "id" => build.id, + "number" => "3", + "state" => "configured", + "duration" => nil, + "event_type" => "push", + "previous_state" => "passed", + "started_at" => "2010-11-12T13:00:00Z", + "finished_at" =>nil, + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/1", + "id" => 1, + "slug" => "svenfuchs/minimal"}, + "branch" => { + "@type" => "branch", + "@href" => "/v3/repo/1/branch/master", + "name" => "master", + "last_build" => { + "@href" => "/v3/build/#{build.id}"}}, + "commit" => { + "@type" => "commit", + "id" => 5, + "sha" => "add057e66c3e1d59ef1f", + "ref" => "refs/heads/master", + "message" => "unignore Gemfile.lock", + "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", + "committed_at" => "2010-11-12T12:55:00Z"}}] + }} + end + + describe "builds on private repository, authenticated as internal application with full access, but scoped to a different org" do + let(:app_name) { 'travis-example' } + let(:app_secret) { '12345678' } + let(:sign_opts) { "a=#{app_name}:s=travis-pro" } + let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} + before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} + + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds", {}, headers) } + before { repo.update_attribute(:private, false) } + + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on private repository, authenticated as internal application with full access, scoped to the right org" do + let(:app_name) { 'travis-example' } + let(:app_secret) { '12345678' } + let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" } + let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} + before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} + + + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } + before { repo.update_attribute(:private, false) } + + + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "builds", + "@href" => "/v3/repo/1/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" => 1 }, + "prev" => nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ + "@type" => "build", + "@href" => "/v3/build/#{build.id}", + "id" => build.id, + "number" => "3", + "state" => "configured", + "duration" => nil, + "event_type" => "push", + "previous_state" => "passed", + "started_at" => "2010-11-12T13:00:00Z", + "finished_at" =>nil, + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/1", + "id" => 1, + "slug" => "svenfuchs/minimal"}, + "branch" => { + "@type" => "branch", + "@href" => "/v3/repo/1/branch/master", + "name" => "master", + "last_build" => { + "@href" => "/v3/build/#{build.id}"}}, + "commit" => { + "@type" => "commit", + "id" => 5, + "sha" => "add057e66c3e1d59ef1f", + "ref" => "refs/heads/master", + "message" => "unignore Gemfile.lock", + "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", + "committed_at" => "2010-11-12T12:55:00Z"}}] + }} + end + + describe "including non-existing field" do + before { get("/v3/repo/#{repo.id}/builds?include=repository.owner,repository.last_build_number") } + example { expect(last_response.status).to be == 400 } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "wrong_params", + "error_message" => "no field \"repository.last_build_number\" to include" + }} + end + + describe "wrong include format" do + before { get("/v3/repo/#{repo.id}/builds?include=repository.last_build.branch") } + example { expect(last_response.status).to be == 400 } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "wrong_params", + "error_message" => "illegal format for include parameter" + }} + end end