From 1c4579008b75f8a1a9c75016487f54b29affdbeb Mon Sep 17 00:00:00 2001 From: Konstantin Haase Date: Thu, 8 Oct 2015 16:32:18 +0200 Subject: [PATCH] v3: broadcasts - make sure expired is a boolean --- lib/travis/api/v3/renderer/broadcast.rb | 4 ++++ spec/v3/services/broadcasts/for_current_user_spec.rb | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/travis/api/v3/renderer/broadcast.rb b/lib/travis/api/v3/renderer/broadcast.rb index da0c528e..7b430985 100644 --- a/lib/travis/api/v3/renderer/broadcast.rb +++ b/lib/travis/api/v3/renderer/broadcast.rb @@ -4,5 +4,9 @@ module Travis::API::V3 class Renderer::Broadcast < Renderer::ModelRenderer representation(:minimal, :id, :recipient_id, :message, :created_at, :category) representation(:standard, :id, :recipient_id, :recipient_type, :category, :kind, :message, :expired, :created_at, :updated_at) + + def expired + model.expired? + end end end diff --git a/spec/v3/services/broadcasts/for_current_user_spec.rb b/spec/v3/services/broadcasts/for_current_user_spec.rb index 64659ead..d41026b0 100644 --- a/spec/v3/services/broadcasts/for_current_user_spec.rb +++ b/spec/v3/services/broadcasts/for_current_user_spec.rb @@ -39,7 +39,7 @@ describe Travis::API::V3::Services::Broadcasts::ForCurrentUser do "category" => broadcasts[0].category, "kind" => nil, "message" => broadcasts[0].message, - "expired" => nil, + "expired" => false, "created_at" => "2010-11-12T13:00:00Z", "updated_at" => "2010-11-12T13:00:00Z" }, { @@ -51,7 +51,7 @@ describe Travis::API::V3::Services::Broadcasts::ForCurrentUser do "category" => broadcasts[1].category, "kind" => nil, "message" => broadcasts[1].message, - "expired" => nil, + "expired" => false, "created_at" => "2010-11-12T13:00:00Z", "updated_at" => "2010-11-12T13:00:00Z"}, { @@ -63,7 +63,7 @@ describe Travis::API::V3::Services::Broadcasts::ForCurrentUser do "category" => broadcasts[2].category, "kind" => nil, "message" => broadcasts[2].message, - "expired" => nil, + "expired" => false, "created_at" => "2010-11-12T13:00:00Z", "updated_at" => "2010-11-12T13:00:00Z"}, { @@ -75,7 +75,7 @@ describe Travis::API::V3::Services::Broadcasts::ForCurrentUser do "category" => broadcasts[3].category, "kind" => nil, "message" => broadcasts[3].message, - "expired" => nil, + "expired" => false, "created_at" => "2010-11-12T13:00:00Z", "updated_at" => "2010-11-12T13:00:00Z"}] }}