suzanne.soy/travis-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Eradicate @builds

Browse Source 
Unclear if ivar is beneficial here.
This commit is contained in:
Hiro Asari 2013-11-11 11:39:06 -05:00
parent 30b60283f8
commit 26bdd84ae6
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/travis/api/app/responders/atom.rb
View File

@ -7,13 +7,13 @@ module Travis::Api::App::Responders
<feed xmlns="http://www.w3.org/2005/Atom"> <feed xmlns="http://www.w3.org/2005/Atom">
<title><%= @builds.first.repository.slug %> Builds</title> <title><%= resource.first.repository.slug %> Builds</title>
<link href="<%= endpoint.url %>" type="application/atom+xml" rel = "self" /> <link href="<%= endpoint.url %>" type="application/atom+xml" rel = "self" />
<id>urn:uuid:<%= SecureRandom.uuid %></id> <id>urn:uuid:<%= SecureRandom.uuid %></id>
<rights>Copyright (c) <%= DateTime.now.strftime("%Y") %> Travis CI GmbH</rights> <rights>Copyright (c) <%= DateTime.now.strftime("%Y") %> Travis CI GmbH</rights>
<updated><%= DateTime.now.strftime %></updated> <updated><%= DateTime.now.strftime %></updated>
<% @builds.each do |build| %> <% resource.each do |build| %>
<entry> <entry>
<title><%= build.repository.slug %> Build #<%= build.number %></title> <title><%= build.repository.slug %> Build #<%= build.number %></title>
<link href="<%= File.join("https://", Travis.config.host, build.repository.slug, "builds", build.id.to_s) %>" /> <link href="<%= File.join("https://", Travis.config.host, build.repository.slug, "builds", build.id.to_s) %>" />
@ -41,10 +41,7 @@ module Travis::Api::App::Responders
EOF EOF
def apply? def apply?
if resource.is_a?(ActiveRecord::Relation) && resource.first.is_a?(Build) super && resource.is_a?(ActiveRecord::Relation) && resource.first.is_a?(Build)
@builds = resource
end
super && @builds
end end
def apply def apply