From 2d0bb58e356d6a334c2bf332724ffcd18de3f71a Mon Sep 17 00:00:00 2001 From: Konstantin Haase Date: Thu, 8 Oct 2015 18:45:18 +0200 Subject: [PATCH] v3: minimal represenations should not use data from other tables --- lib/travis/api/v3/renderer/build.rb | 4 ++-- lib/travis/api/v3/renderer/repository.rb | 2 +- lib/travis/api/v3/services/broadcasts/for_current_user.rb | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/travis/api/v3/renderer/build.rb b/lib/travis/api/v3/renderer/build.rb index 4bca9f68..9c90c593 100644 --- a/lib/travis/api/v3/renderer/build.rb +++ b/lib/travis/api/v3/renderer/build.rb @@ -2,8 +2,8 @@ require 'travis/api/v3/renderer/model_renderer' module Travis::API::V3 class Renderer::Build < Renderer::ModelRenderer - representation(:minimal, :id, :number, :state, :duration, :event_type, :previous_state, :started_at, :finished_at, :jobs) - representation(:standard, *representations[:minimal], :repository, :branch, :commit) + representation(:minimal, :id, :number, :state, :duration, :event_type, :previous_state, :started_at, :finished_at) + representation(:standard, *representations[:minimal], :repository, :branch, :commit, :jobs) def jobs return model.jobs if include_full_jobs? diff --git a/lib/travis/api/v3/renderer/repository.rb b/lib/travis/api/v3/renderer/repository.rb index 2bb4a75a..c410235c 100644 --- a/lib/travis/api/v3/renderer/repository.rb +++ b/lib/travis/api/v3/renderer/repository.rb @@ -2,7 +2,7 @@ require 'travis/api/v3/renderer/model_renderer' module Travis::API::V3 class Renderer::Repository < Renderer::ModelRenderer - representation(:minimal, :id, :slug, :default_branch) + representation(:minimal, :id, :name, :slug) representation(:standard, :id, :name, :slug, :description, :github_language, :active, :private, :owner, :last_build, :default_branch) def active diff --git a/lib/travis/api/v3/services/broadcasts/for_current_user.rb b/lib/travis/api/v3/services/broadcasts/for_current_user.rb index 0393fb98..0515d11f 100644 --- a/lib/travis/api/v3/services/broadcasts/for_current_user.rb +++ b/lib/travis/api/v3/services/broadcasts/for_current_user.rb @@ -1,5 +1,7 @@ module Travis::API::V3 class Services::Broadcasts::ForCurrentUser < Service + params :active, prefix: :broadcast + def run! raise LoginRequired unless access_control.logged_in? query.for_user(access_control.user)