Popup should be open only if thirdPartyCookies are disabled
This commit is contained in:
parent
bbbe0e0c67
commit
33dced826b
|
@ -139,6 +139,7 @@ class Travis::Api::App
|
||||||
|
|
||||||
get '/check_cookie' do
|
get '/check_cookie' do
|
||||||
content_type :js
|
content_type :js
|
||||||
|
Travis.logger.info [:cookies, request.cookies, env['HTTP_COOKIE']]
|
||||||
"cookiesCheckCallback(%p)" % request.cookies.include?('foo')
|
"cookiesCheckCallback(%p)" % request.cookies.include?('foo')
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -292,9 +293,9 @@ alert('refusing to send a token to <%= target_origin.inspect %>, not whitelisted
|
||||||
|
|
||||||
function cookiesCheckCallback(thirdPartyCookiesEnabled) {
|
function cookiesCheckCallback(thirdPartyCookiesEnabled) {
|
||||||
if(thirdPartyCookiesEnabled) {
|
if(thirdPartyCookiesEnabled) {
|
||||||
window.open(url, 'Signing in...', 'height=400,width=800');
|
|
||||||
} else {
|
|
||||||
document.write('<iframe src="'+url+'" />');
|
document.write('<iframe src="'+url+'" />');
|
||||||
|
} else {
|
||||||
|
window.open(url, 'Signing in...', 'height=400,width=800');
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
</script>
|
</script>
|
||||||
|
|
Loading…
Reference in New Issue
Block a user