From 477c8b9212d12509870b0c8736ad58581ac82f51 Mon Sep 17 00:00:00 2001 From: Hiro Asari Date: Wed, 11 Jun 2014 20:19:57 -0400 Subject: [PATCH] Tweak RemoveLog helper Leave responding up to the endpoint Remove unnecessary parameter from the helper's parameter --- lib/travis/api/app/endpoint/jobs.rb | 2 +- lib/travis/api/app/endpoint/logs.rb | 4 ++-- lib/travis/api/app/helpers.rb | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/travis/api/app/endpoint/jobs.rb b/lib/travis/api/app/endpoint/jobs.rb index a6d4b8a7..29eecdee 100644 --- a/lib/travis/api/app/endpoint/jobs.rb +++ b/lib/travis/api/app/endpoint/jobs.rb @@ -67,7 +67,7 @@ class Travis::Api::App end patch '/:id/log', scope: :private do |id| - patch_log_for_job(id, params) + respond_with patch_log_for_job(params) end get "/:job_id/annotations" do diff --git a/lib/travis/api/app/endpoint/logs.rb b/lib/travis/api/app/endpoint/logs.rb index a7bda278..edf59467 100644 --- a/lib/travis/api/app/endpoint/logs.rb +++ b/lib/travis/api/app/endpoint/logs.rb @@ -12,8 +12,8 @@ class Travis::Api::App # Clears up the content of the log by the *job id* # Optionally takes parameter *reason* - patch '/:id' do |id| - patch_log_for_job(id, params) + patch '/:id' do + respond_with patch_log_for_job(params) end end end diff --git a/lib/travis/api/app/helpers.rb b/lib/travis/api/app/helpers.rb index fe1cfd02..1522f8f0 100644 --- a/lib/travis/api/app/helpers.rb +++ b/lib/travis/api/app/helpers.rb @@ -5,9 +5,8 @@ class Travis::Api::App module Helpers Backports.require_relative_dir 'helpers' - def patch_log_for_job(id, params) - result = self.service(:remove_log, params) - respond_with result + def patch_log_for_job(params) + self.service(:remove_log, params).run rescue Travis::AuthorizationDenied => ade status 401 { error: { message: ade.message } }