suzanne.soy/travis-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v3: add owner_name and name to sidekiq payload when creating a new request

Browse Source
This commit is contained in:
Konstantin Haase 2015-03-24 12:34:37 +01:00
parent e4f868cea7
commit 4ae3f5e171
2 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/travis/api/v3/queries/request.rb
View File

@ -7,8 +7,8 @@ module Travis::API::V3
raise WrongParams, 'missing user'.freeze unless user and user.id raise WrongParams, 'missing user'.freeze unless user and user.id
payload = { payload = {
repository: { id: repository.github_id }, repository: { id: repository.github_id, owner_name: repository.owner_name, name: repository.name },
user: { id: user.id }, user: { id: user.id },
message: message, message: message,
branch: branch || repository.default_branch_name, branch: branch || repository.default_branch_name,
config: config || {} config: config || {}

28
spec/v3/services/requests/create_spec.rb
View File

@ -88,7 +88,7 @@ describe Travis::API::V3::Services::Requests::Create do
"remaining_requests" => 10, "remaining_requests" => 10,
"repository" => {"@type"=>"repository", "@href"=>"/repo/#{repo.id}", "id"=>repo.id, "slug"=>"svenfuchs/minimal"}, "repository" => {"@type"=>"repository", "@href"=>"/repo/#{repo.id}", "id"=>repo.id, "slug"=>"svenfuchs/minimal"},
"request" => { "request" => {
"repository" => {"id"=>repo.id}, "repository" => {"id"=>repo.id, "owner_name"=>"svenfuchs", "name"=>"minimal"},
"user" => {"id"=>repo.owner.id}, "user" => {"id"=>repo.owner.id},
"message" => nil, "message" => nil,
"branch" => "master", "branch" => "master",
@ -97,7 +97,7 @@ describe Travis::API::V3::Services::Requests::Create do
}} }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'master', branch: 'master',
@ -110,7 +110,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "setting id has no effect" do describe "setting id has no effect" do
let(:params) {{ id: 42 }} let(:params) {{ id: 42 }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'master', branch: 'master',
@ -121,7 +121,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "setting repository has no effect" do describe "setting repository has no effect" do
let(:params) {{ repository: { id: 42 } }} let(:params) {{ repository: { id: 42 } }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'master', branch: 'master',
@ -132,7 +132,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "setting user has no effect" do describe "setting user has no effect" do
let(:params) {{ user: { id: 42 } }} let(:params) {{ user: { id: 42 } }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'master', branch: 'master',
@ -143,7 +143,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "overriding config" do describe "overriding config" do
let(:params) {{ config: { script: 'true' } }} let(:params) {{ config: { script: 'true' } }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'master', branch: 'master',
@ -154,7 +154,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "overriding message" do describe "overriding message" do
let(:params) {{ message: 'example' }} let(:params) {{ message: 'example' }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: 'example', message: 'example',
branch: 'master', branch: 'master',
@ -165,7 +165,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "overriding branch" do describe "overriding branch" do
let(:params) {{ branch: 'example' }} let(:params) {{ branch: 'example' }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'example', branch: 'example',
@ -176,7 +176,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "overriding branch (in request)" do describe "overriding branch (in request)" do
let(:params) {{ request: { branch: 'example' } }} let(:params) {{ request: { branch: 'example' } }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'example', branch: 'example',
@ -187,7 +187,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "overriding branch (with request prefix)" do describe "overriding branch (with request prefix)" do
let(:params) {{ "request.branch" => 'example' }} let(:params) {{ "request.branch" => 'example' }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'example', branch: 'example',
@ -198,7 +198,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "overriding branch (with request type)" do describe "overriding branch (with request type)" do
let(:params) {{ "@type" => "request", "branch" => 'example' }} let(:params) {{ "@type" => "request", "branch" => 'example' }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'example', branch: 'example',
@ -209,7 +209,7 @@ describe Travis::API::V3::Services::Requests::Create do
describe "overriding branch (with wrong type)" do describe "overriding branch (with wrong type)" do
let(:params) {{ "@type" => "repository", "branch" => 'example' }} let(:params) {{ "@type" => "repository", "branch" => 'example' }}
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'master', branch: 'master',
@ -255,7 +255,7 @@ describe Travis::API::V3::Services::Requests::Create do
let(:params) {{ user: { id: repo.owner.id } }} let(:params) {{ user: { id: repo.owner.id } }}
example { expect(last_response.status).to be == 202 } example { expect(last_response.status).to be == 202 }
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'master', branch: 'master',
@ -267,7 +267,7 @@ describe Travis::API::V3::Services::Requests::Create do
let(:params) {{ user: { id: repo.owner.id }, branch: 'example' }} let(:params) {{ user: { id: repo.owner.id }, branch: 'example' }}
example { expect(last_response.status).to be == 202 } example { expect(last_response.status).to be == 202 }
example { expect(sidekiq_payload).to be == { example { expect(sidekiq_payload).to be == {
repository: { id: repo.id }, repository: { id: repo.id, owner_name: 'svenfuchs', name: 'minimal' },
user: { id: repo.owner.id }, user: { id: repo.owner.id },
message: nil, message: nil,
branch: 'example', branch: 'example',