From 50e198beee39ddd3b139e7c00df9dbef387066bf Mon Sep 17 00:00:00 2001 From: carlad Date: Tue, 1 Dec 2015 15:02:10 +0100 Subject: [PATCH] v3: tidy specs for star, unstar, enable, disable --- spec/v3/services/repository/disable_spec.rb | 3 --- spec/v3/services/repository/enable_spec.rb | 5 +---- spec/v3/services/repository/star_spec.rb | 2 +- spec/v3/services/repository/unstar_spec.rb | 25 +-------------------- 4 files changed, 3 insertions(+), 32 deletions(-) diff --git a/spec/v3/services/repository/disable_spec.rb b/spec/v3/services/repository/disable_spec.rb index e5ef635e..991c2dd8 100644 --- a/spec/v3/services/repository/disable_spec.rb +++ b/spec/v3/services/repository/disable_spec.rb @@ -5,7 +5,6 @@ describe Travis::API::V3::Services::Repository::Disable do before do repo.update_attributes!(active: true) - Travis::Features.stubs(:owner_active?).returns(true) end describe "not authenticated" do @@ -70,6 +69,4 @@ describe Travis::API::V3::Services::Repository::Disable do describe "existing repository, push access" # as this reqires a call to github, and stubbing this request has proven difficult, # this test has been omitted for now - - end diff --git a/spec/v3/services/repository/enable_spec.rb b/spec/v3/services/repository/enable_spec.rb index 10c70cb6..fca71c2e 100644 --- a/spec/v3/services/repository/enable_spec.rb +++ b/spec/v3/services/repository/enable_spec.rb @@ -4,8 +4,7 @@ describe Travis::API::V3::Services::Repository::Enable do let(:repo) { Travis::API::V3::Models::Repository.where(owner_name: 'svenfuchs', name: 'minimal').first } before do - repo.update_attributes!(active: true) - Travis::Features.stubs(:owner_active?).returns(true) + repo.update_attributes!(active: false) end describe "not authenticated" do @@ -70,6 +69,4 @@ describe Travis::API::V3::Services::Repository::Enable do describe "existing repository, push access" # as this reqires a call to github, and stubbing this request has proven difficult, # this test has been omitted for now - - end diff --git a/spec/v3/services/repository/star_spec.rb b/spec/v3/services/repository/star_spec.rb index 8fcc26e4..f946af9b 100644 --- a/spec/v3/services/repository/star_spec.rb +++ b/spec/v3/services/repository/star_spec.rb @@ -4,7 +4,7 @@ describe Travis::API::V3::Services::Repository::Star do let(:repo) { Travis::API::V3::Models::Repository.where(owner_name: 'svenfuchs', name: 'minimal').first } before do - Travis::Features.stubs(:owner_active?).returns(true) + # Travis::Features.stubs(:owner_active?).returns(true) end describe "not authenticated" do diff --git a/spec/v3/services/repository/unstar_spec.rb b/spec/v3/services/repository/unstar_spec.rb index d66768ad..22b9f8be 100644 --- a/spec/v3/services/repository/unstar_spec.rb +++ b/spec/v3/services/repository/unstar_spec.rb @@ -86,28 +86,5 @@ describe Travis::API::V3::Services::Repository::Unstar do "id") } example { expect(Travis::API::V3::Models::Star.where(user_id: repo.owner_id, repository_id: repo.id)).to be == []} - end - - - # TODO return an error when alreasy not on the star db - - describe "existing repository, push access, already starred" do - let(:params) {{}} - let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } - let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} - before { Travis::API::V3::Models::Permission.create(repository: repo, user: repo.owner, push: true) } - before { post("/v3/repo/#{repo.id}/unstar", params, headers) } - - example { expect(last_response.status).to be == 403 } - example { expect(JSON.load(body).to_s).to include( - "@type", - "star", - "@href", - "@representation", - "minimal", - "false", - "id") - } - example { expect(Travis::API::V3::Models::Star.where(user_id: repo.owner_id, repository_id: repo.id)).to be == "idushifuhds"} - end + end end