From 73f724c58cac86a6ecf5c3d350b266e7d62f1e06 Mon Sep 17 00:00:00 2001
From: Hiro Asari <asari.ruby@gmail.com>
Date: Mon, 7 Mar 2016 16:36:33 -1000
Subject: [PATCH] Add more specs for `/job/:job_id/debug`

We now rely on https://github.com/travis-ci/travis-core/pull/519.
---
 Gemfile                            |  2 +-
 Gemfile.lock                       |  7 ++--
 spec/v3/services/job/debug_sepc.rb | 61 ++++++++++++++++++++++++------
 3 files changed, 55 insertions(+), 15 deletions(-)

diff --git a/Gemfile b/Gemfile
index 9893ebf5..0a612122 100644
--- a/Gemfile
+++ b/Gemfile
@@ -5,7 +5,7 @@ ruby '2.1.7' if ENV.key?('DYNO')
 
 gem 's3',              github: 'travis-ci/s3'
 
-gem 'travis-core',     github: 'travis-ci/travis-core'
+gem 'travis-core',     github: 'travis-ci/travis-core', branch: 'ha-feature-debug-endpoint'
 gem 'travis-support',  github: 'travis-ci/travis-support'
 gem 'travis-config',   '~> 0.1.0'
 gem 'travis-sidekiqs', github: 'travis-ci/travis-sidekiqs', require: nil
diff --git a/Gemfile.lock b/Gemfile.lock
index 29745665..06399e45 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -50,7 +50,8 @@ GIT
 
 GIT
   remote: git://github.com/travis-ci/travis-core.git
-  revision: 96ee8c449ebe305c5c95633cea13eb88fe978abb
+  revision: 501f31a40af589b5ea8a677e7f8b067949a322b2
+  branch: ha-feature-debug-endpoint
   specs:
     travis-core (0.0.1)
       actionmailer (~> 3.2.19)
@@ -193,9 +194,9 @@ GEM
     httparty (0.11.0)
       multi_json (~> 1.0)
       multi_xml (>= 0.5.2)
-    httpclient (2.7.0.1)
+    httpclient (2.7.1)
     i18n (0.7.0)
-    ice_nine (0.11.1)
+    ice_nine (0.11.2)
     jemalloc (1.0.1)
     journey (1.0.4)
     json (1.8.3)
diff --git a/spec/v3/services/job/debug_sepc.rb b/spec/v3/services/job/debug_sepc.rb
index 3e3376e9..03fe80fb 100644
--- a/spec/v3/services/job/debug_sepc.rb
+++ b/spec/v3/services/job/debug_sepc.rb
@@ -2,8 +2,12 @@ require 'spec_helper'
 
 describe Travis::API::V3::Services::Job::Debug do
   let(:repo) { Travis::API::V3::Models::Repository.where(owner_name: 'svenfuchs', name: 'minimal').first }
-  let(:sidekiq_payload) { JSON.load(Sidekiq::Client.last['args'].last[:payload]).deep_symbolize_keys }
-  let(:sidekiq_params) { Sidekiq::Client.last['args'].last.deep_symbolize_keys }
+  let(:owner_type)  { repo.owner_type.constantize }
+  let(:owner)       { owner_type.find(repo.owner_id)}
+  let(:build)       { repo.builds.last }
+  let(:jobs)        { Travis::API::V3::Models::Build.find(build.id).jobs }
+  let(:job)         { jobs.last }
+
   before { repo.requests.each(&:delete) }
 
   before do
@@ -11,6 +15,8 @@ describe Travis::API::V3::Services::Job::Debug do
     @original_sidekiq = Sidekiq::Client
     Sidekiq.send(:remove_const, :Client) # to avoid a warning
     Sidekiq::Client = []
+
+    Travis.config.stubs(:debug_tools_enabled).returns true
   end
 
   after do
@@ -18,14 +24,47 @@ describe Travis::API::V3::Services::Job::Debug do
     Sidekiq::Client = @original_sidekiq
   end
 
-  describe "not authenticated" do
-    before  { post("/v3/job/#{job.id}/debug")      }
-    example { expect(last_response.status).to be == 403 }
-    example { expect(JSON.load(body)).to      be ==     {
-      "@type"         => "error",
-      "error_type"    => "login_required",
-      "error_message" => "login required"
-    }}
-  end
+  describe "#run" do
+    context "when unauthenticated" do
+      before  { post("/v3/job/#{job.id}/debug")      }
+      example { expect(last_response.status).to be == 403 }
+      example { expect(JSON.load(body)).to      be ==     {
+        "@type"         => "error",
+        "error_type"    => "login_required",
+        "error_message" => "login required"
+      }}
+    end
 
+    context "when authenticated" do
+      let(:token)   { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) }
+      let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}"                        }}
+
+      context "without sufficient authorization" do
+        before { post("/v3/job/#{job.id}/debug", {}, headers) }
+
+        example { expect(last_response.status).to be == 403 }
+        example { expect(JSON.load(body)).to include(
+          "@type"         => "error",
+          "error_type"    => "insufficient_access",
+          "error_message" => "operation requires debug access to job",
+          "resource_type" => "job",
+        )}
+      end
+
+      context "with sufficient authorization" do
+        let(:params) {{}}
+
+        before { Travis::API::V3::Models::Permission.create(repository: repo, user: repo.owner, push: true) }
+        before { post("/v3/job/#{job.id}/debug", {}, headers) }
+
+        example { expect(last_response.status).to be == 202 }
+
+        example { expect(job.reload.debug_options).to include(
+          stage: "before_install",
+          created_by: owner.login,
+          quiet: false
+        ) }
+      end
+    end
+  end
 end
\ No newline at end of file