diff --git a/lib/travis/api/app/endpoint/authorization.rb b/lib/travis/api/app/endpoint/authorization.rb index 6e2a7aa5..65ed8573 100644 --- a/lib/travis/api/app/endpoint/authorization.rb +++ b/lib/travis/api/app/endpoint/authorization.rb @@ -276,8 +276,8 @@ class Travis::Api::App user end - def get_token(endoint, values) - response = Faraday.new(ssl: Travis.config.github.ssl).post(endoint, values) + def get_token(endpoint, values) + response = Faraday.new(ssl: Travis.config.github.ssl).post(endpoint, values) parameters = Addressable::URI.form_unencode(response.body) token_info = parameters.assoc("access_token") halt 401, 'could not resolve github token' unless token_info diff --git a/spec/unit/endpoint/authorization_spec.rb b/spec/unit/endpoint/authorization_spec.rb index e2cc59d1..33c76e84 100644 --- a/spec/unit/endpoint/authorization_spec.rb +++ b/spec/unit/endpoint/authorization_spec.rb @@ -75,6 +75,8 @@ describe Travis::Api::App::Endpoint::Authorization do User::Oauth.instance_variable_set("@wanted_scopes", nil) end + # in endpoint/authorization.rb 271, get_token faraday raises the exception: + # hostname "foobar.com" does not match the server certificate it 'redirects to insufficient access page' do response = get '/auth/handshake?state=github-state&code=oauth-code' response.should redirect_to('https://travis-ci.org/insufficient_access')