From 79c14d697e262e59c34efb4dc42dac95a693f95e Mon Sep 17 00:00:00 2001 From: Igor Wiedler Date: Tue, 5 Jul 2016 13:02:00 +0200 Subject: [PATCH] only create/allocate GitHub CIDR object once --- lib/travis/api/attack.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/travis/api/attack.rb b/lib/travis/api/attack.rb index a834e38a..130431b0 100644 --- a/lib/travis/api/attack.rb +++ b/lib/travis/api/attack.rb @@ -32,13 +32,15 @@ class Rack::Attack "/auth/post_message/iframe" ] + GITHUB_CIDR = NetAddr::CIDR.create('192.30.252.0/22') + whitelist('safelist build status images') do |request| /\.(png|svg)$/.match(request.path) end # https://help.github.com/articles/what-ip-addresses-does-github-use-that-i-should-whitelist/ whitelist('safelist anything coming from github') do |request| - request.ip && NetAddr::CIDR.create('192.30.252.0/22').contains?(request.ip) + request.ip && GITHUB_CIDR.contains?(request.ip) end ####