From 8ef0a2d8e58991e98447ae8ae27a132e3e7a0c4b Mon Sep 17 00:00:00 2001 From: carlad Date: Fri, 21 Aug 2015 14:39:28 +0200 Subject: [PATCH 1/6] implement requests --- lib/travis/api/v3/renderer/request.rb | 8 ++++++++ lib/travis/api/v3/services.rb | 2 +- lib/travis/api/v3/services/requests/find.rb | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 lib/travis/api/v3/renderer/request.rb diff --git a/lib/travis/api/v3/renderer/request.rb b/lib/travis/api/v3/renderer/request.rb new file mode 100644 index 00000000..356a74fe --- /dev/null +++ b/lib/travis/api/v3/renderer/request.rb @@ -0,0 +1,8 @@ +require 'travis/api/v3/renderer/model_renderer' + +module Travis::API::V3 + class Renderer::Request < Renderer::ModelRenderer + representation(:minimal, :id) + representation(:standard, :id, :repository, :commit, :owner, :created_at, :result, :message, :event_type) + end +end diff --git a/lib/travis/api/v3/services.rb b/lib/travis/api/v3/services.rb index 4aabfb7c..85ecef01 100644 --- a/lib/travis/api/v3/services.rb +++ b/lib/travis/api/v3/services.rb @@ -5,7 +5,7 @@ module Travis::API::V3 Accounts = Module.new { extend Services } Branch = Module.new { extend Services } Build = Module.new { extend Services } - Builds = Module.new { extend Services } + Builds = Module.new { extend Services } Organization = Module.new { extend Services } Organizations = Module.new { extend Services } Owner = Module.new { extend Services } diff --git a/lib/travis/api/v3/services/requests/find.rb b/lib/travis/api/v3/services/requests/find.rb index 80383bbe..653f12a1 100644 --- a/lib/travis/api/v3/services/requests/find.rb +++ b/lib/travis/api/v3/services/requests/find.rb @@ -1,4 +1,7 @@ module Travis::API::V3 class Services::Requests::Find < Service + def run! + query.find(find(:repository)) + end end end From 456f52405e6b3de878f3431b3a6c38a793a1f9e4 Mon Sep 17 00:00:00 2001 From: carlad Date: Fri, 21 Aug 2015 17:07:06 +0200 Subject: [PATCH 2/6] add builds spec --- spec/v3/services/builds/find_spec.rb | 357 +++++++++++++++++++++++++++ 1 file changed, 357 insertions(+) create mode 100644 spec/v3/services/builds/find_spec.rb diff --git a/spec/v3/services/builds/find_spec.rb b/spec/v3/services/builds/find_spec.rb new file mode 100644 index 00000000..d283fe34 --- /dev/null +++ b/spec/v3/services/builds/find_spec.rb @@ -0,0 +1,357 @@ +require 'spec_helper' + +describe Travis::API::V3::Services::Builds::Find do + let(:repo) { Repository.by_slug('svenfuchs/minimal').first } + let(:build) { repo.builds.first } + let(:parsed_body) { JSON.load(body) } + + describe "fetching builds on a public repository by slug" do + before { get("/v3/repo/svenfuchs%2Fminimal/builds") } + example { expect(last_response).to be_ok } + end + + describe "fetching builds on a non-existing repository by slug" do + before { get("/v3/repo/svenfuchs%2Fminimal1/builds") } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on public repository" do + before { get("/v3/repo/#{repo.id}/builds?limit=1") } + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "builds", + "@href" => "/v3/repo/#{repo.id}/builds", + "builds" => { + "@type" => "build", + "@href" => "/v3/build/#{build.id}", + "id" => build.id, + "number" => "3", + "state" => "configured", + "duration" => nil, + "event_type" => "push", + "previous_state" => "passed", + "started_at" => "2010-11-12T13:00:00Z", + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/1", + "id" => 1, + "slug"=>"svenfuchs/minimal" }, + "branch" => { + "@type" => "branch", + "@href" => "/v3/repo/1/branch/master", + "name" => "master", + "last_build" => { + "@href"=>"/v3/build/62" }}, + "commit" => { + "@type" => "commit", + "id" => 5, + "sha" => "add057e66c3e1d59ef1f", + "ref" => "refs/heads/master", + "message" => "unignore Gemfile.lock", + "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", + "committed_at" => "2010-11-12T12:55:00Z"}}, + }} + end +# +# describe "missing repository" do +# before { get("/v3/repo/999999999999999") } +# example { expect(last_response).to be_not_found } +# example { expect(parsed_body).to be == { +# "@type" => "error", +# "error_type" => "not_found", +# "error_message" => "repository not found (or insufficient access)", +# "resource_type" => "repository" +# }} +# end +# +# describe "public repository, private API" do +# before { Travis.config.private_api = true } +# before { get("/v3/repo/#{repo.id}") } +# after { Travis.config.private_api = false } +# example { expect(last_response).to be_not_found } +# example { expect(parsed_body).to be == { +# "@type" => "error", +# "error_type" => "not_found", +# "error_message" => "repository not found (or insufficient access)", +# "resource_type" => "repository" +# }} +# end +# +# describe "private repository, not authenticated" do +# before { repo.update_attribute(:private, true) } +# before { get("/v3/repo/#{repo.id}") } +# before { repo.update_attribute(:private, false) } +# example { expect(last_response).to be_not_found } +# example { expect(parsed_body).to be == { +# "@type" => "error", +# "error_type" => "not_found", +# "error_message" => "repository not found (or insufficient access)", +# "resource_type" => "repository" +# }} +# end +# +# describe "private repository, private API, authenticated as user with access" do +# let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } +# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} +# before { Permission.create(repository: repo, user: repo.owner, pull: true) } +# before { repo.update_attribute(:private, true) } +# before { get("/v3/repo/#{repo.id}", {}, headers) } +# after { repo.update_attribute(:private, false) } +# example { expect(last_response).to be_ok } +# example { expect(parsed_body).to be == { +# "@type" => "repository", +# "@href" => "/v3/repo/#{repo.id}", +# "@permissions" => { +# "read" => true, +# "enable" => false, +# "disable" => false, +# "create_request" => false}, +# "id" => repo.id, +# "name" => "minimal", +# "slug" => "svenfuchs/minimal", +# "description" => nil, +# "github_language" => nil, +# "active" => true, +# "private" => true, +# "owner" => { +# "@type" => "user", +# "@href" => "/v3/user/#{repo.owner_id}", +# "id" => repo.owner_id, +# "login" => "svenfuchs" }, +# "last_build" => { +# "@type" => "build", +# "@href" => "/v3/build/#{repo.last_build_id}", +# "id" => repo.last_build_id, +# "number" => "2", +# "state" => "passed", +# "duration" => nil, +# "started_at" => "2010-11-12T12:30:00Z", +# "finished_at" => "2010-11-12T12:30:20Z"}, +# "default_branch" => { +# "@type" => "branch", +# "@href" => "/v3/repo/#{repo.id}/branch/master", +# "name" => "master", +# "last_build" => { +# "@type" => "build", +# "@href" => "/v3/build/#{repo.last_build.id}", +# "id" => repo.last_build.id, +# "number" => "3", +# "state" => "configured", +# "duration" => nil, +# "event_type" => "push", +# "previous_state" => "passed", +# "started_at" => "2010-11-12T13:00:00Z", +# "finished_at" => nil}} +# }} +# end +# +# describe "private repository, private API, authenticated as user without access" do +# let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) } +# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} +# before { repo.update_attribute(:private, true) } +# before { get("/v3/repo/#{repo.id}", {}, headers) } +# before { repo.update_attribute(:private, false) } +# example { expect(last_response).to be_not_found } +# example { expect(parsed_body).to be == { +# "@type" => "error", +# "error_type" => "not_found", +# "error_message" => "repository not found (or insufficient access)", +# "resource_type" => "repository" +# }} +# end +# +# describe "private repository, authenticated as internal application with full access" do +# let(:app_name) { 'travis-example' } +# let(:app_secret) { '12345678' } +# let(:sign_opts) { "a=#{app_name}" } +# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } +# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} +# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} +# +# +# before { repo.update_attribute(:private, true) } +# before { get("/v3/repo/#{repo.id}", {}, headers) } +# before { repo.update_attribute(:private, false) } +# +# +# example { expect(last_response).to be_ok } +# example { expect(parsed_body).to be == { +# "@type" => "repository", +# "@href" => "/v3/repo/#{repo.id}", +# "@permissions" => { +# "read" => true, +# "enable" => true, +# "disable" => true, +# "create_request" => true}, +# "id" => repo.id, +# "name" => "minimal", +# "slug" => "svenfuchs/minimal", +# "description" => nil, +# "github_language" => nil, +# "active" => true, +# "private" => true, +# "owner" => { +# "@type" => "user", +# "@href" => "/v3/user/#{repo.owner_id}", +# "id" => repo.owner_id, +# "login" => "svenfuchs" }, +# "last_build" => { +# "@type" => "build", +# "@href" => "/v3/build/#{repo.last_build_id}", +# "id" => repo.last_build_id, +# "number" => "2", +# "state" => "passed", +# "duration" => nil, +# "started_at" => "2010-11-12T12:30:00Z", +# "finished_at" => "2010-11-12T12:30:20Z"}, +# "default_branch" => { +# "@type" => "branch", +# "@href" => "/v3/repo/#{repo.id}/branch/master", +# "name" => "master", +# "last_build" => { +# "@type" => "build", +# "@href" => "/v3/build/#{repo.last_build.id}", +# "id" => repo.last_build.id, +# "number" => "3", +# "state" => "configured", +# "duration" => nil, +# "event_type" => "push", +# "previous_state" => "passed", +# "started_at" => "2010-11-12T13:00:00Z", +# "finished_at" => nil}} +# }} +# end +# +# describe "private repository, authenticated as internal application with full access, but scoped to a different org" do +# let(:app_name) { 'travis-example' } +# let(:app_secret) { '12345678' } +# let(:sign_opts) { "a=#{app_name}:s=travis-pro" } +# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } +# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} +# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} +# +# before { repo.update_attribute(:private, true) } +# before { get("/v3/repo/#{repo.id}", {}, headers) } +# before { repo.update_attribute(:private, false) } +# +# example { expect(last_response).to be_not_found } +# example { expect(parsed_body).to be == { +# "@type" => "error", +# "error_type" => "not_found", +# "error_message" => "repository not found (or insufficient access)", +# "resource_type" => "repository" +# }} +# end +# +# describe "private repository, authenticated as internal application with full access, scoped to the right org" do +# let(:app_name) { 'travis-example' } +# let(:app_secret) { '12345678' } +# let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" } +# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } +# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} +# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} +# +# +# before { repo.update_attribute(:private, true) } +# before { get("/v3/repo/#{repo.id}", {}, headers) } +# before { repo.update_attribute(:private, false) } +# +# +# example { expect(last_response).to be_ok } +# example { expect(parsed_body).to be == { +# "@type" => "repository", +# "@href" => "/v3/repo/#{repo.id}", +# "@permissions" => { +# "read" => true, +# "enable" => true, +# "disable" => true, +# "create_request" => true}, +# "id" => repo.id, +# "name" => "minimal", +# "slug" => "svenfuchs/minimal", +# "description" => nil, +# "github_language" => nil, +# "active" => true, +# "private" => true, +# "owner" => { +# "@type" => "user", +# "@href" => "/v3/user/#{repo.owner_id}", +# "id" => repo.owner_id, +# "login" => "svenfuchs" }, +# "last_build" => { +# "@type" => "build", +# "@href" => "/v3/build/#{repo.last_build_id}", +# "id" => repo.last_build_id, +# "number" => "2", +# "state" => "passed", +# "duration" => nil, +# "started_at" => "2010-11-12T12:30:00Z", +# "finished_at" => "2010-11-12T12:30:20Z"}, +# "default_branch" => { +# "@type" => "branch", +# "@href" => "/v3/repo/#{repo.id}/branch/master", +# "name" => "master", +# "last_build" => { +# "@type" => "build", +# "@href" => "/v3/build/#{repo.last_build.id}", +# "id" => repo.last_build.id, +# "number" => "3", +# "state" => "configured", +# "duration" => nil, +# "event_type" => "push", +# "previous_state" => "passed", +# "started_at" => "2010-11-12T13:00:00Z", +# "finished_at" => nil}} +# }} +# end +# +# describe "including full owner" do +# before { get("/v3/repo/#{repo.id}?include=repository.owner") } +# example { expect(last_response).to be_ok } +# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at", +# "@type" => "user", +# "id" => repo.owner_id, +# "login" => "svenfuchs", +# )} +# end +# +# describe "including full owner and full last build" do +# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build") } +# example { expect(last_response).to be_ok } +# example { expect(parsed_body['last_build']['state']).to be == 'passed' } +# example { expect(parsed_body['last_build']['repository']).to be == { "@href" => "/v3/repo/#{repo.id}" } } +# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at")} +# end +# +# describe "including non-existing field" do +# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build_number") } +# example { expect(last_response.status).to be == 400 } +# example { expect(parsed_body).to be == { +# "@type" => "error", +# "error_type" => "wrong_params", +# "error_message" => "no field \"repository.last_build_number\" to include" +# }} +# end +# +# describe "wrong include format" do +# before { get("/v3/repo/#{repo.id}?include=repository.last_build.branch") } +# example { expect(last_response.status).to be == 400 } +# example { expect(parsed_body).to be == { +# "@type" => "error", +# "error_type" => "wrong_params", +# "error_message" => "illegal format for include parameter" +# }} +# end +# +# describe "including nested objects" do +# before { get("/v3/repo/#{repo.id}?include=repository.last_build,build.branch") } +# example { expect(last_response).to be_ok } +# example { expect(parsed_body).to include("last_build") } +# end +end From a7111ba949f08acf29e3aa9ee6bff949e6f51261 Mon Sep 17 00:00:00 2001 From: carlad Date: Mon, 24 Aug 2015 09:48:29 +0200 Subject: [PATCH 3/6] add database.yml to .gitignore --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index ee2d0102..4d67597c 100644 --- a/.gitignore +++ b/.gitignore @@ -1,8 +1,8 @@ config/travis.yml +config/database.yml .yardoc log/ vendor config/skylight.yml .coverage *.env -tmp From 96a79be68cc1e05b421ea6becca054301f640de6 Mon Sep 17 00:00:00 2001 From: carlad Date: Mon, 24 Aug 2015 10:01:34 +0200 Subject: [PATCH 4/6] v3 remove blank spaces --- spec/v3/services/builds/find_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/v3/services/builds/find_spec.rb b/spec/v3/services/builds/find_spec.rb index d283fe34..b14ab715 100644 --- a/spec/v3/services/builds/find_spec.rb +++ b/spec/v3/services/builds/find_spec.rb @@ -22,7 +22,7 @@ describe Travis::API::V3::Services::Builds::Find do end describe "builds on public repository" do - before { get("/v3/repo/#{repo.id}/builds?limit=1") } + before { get("/v3/repo/#{repo.id}/builds?limit=1") } example { expect(last_response).to be_ok } example { expect(parsed_body).to be == { "@type" => "builds", From 11f5f2cb667fea75f61595fb353f1bdc2434b7ee Mon Sep 17 00:00:00 2001 From: carlad Date: Mon, 24 Aug 2015 13:27:27 +0200 Subject: [PATCH 5/6] v3 finish builds/find_spec tests --- spec/v3/services/builds/find_spec.rb | 622 ++++++++++++++------------- 1 file changed, 321 insertions(+), 301 deletions(-) diff --git a/spec/v3/services/builds/find_spec.rb b/spec/v3/services/builds/find_spec.rb index b14ab715..71d6555f 100644 --- a/spec/v3/services/builds/find_spec.rb +++ b/spec/v3/services/builds/find_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' describe Travis::API::V3::Services::Builds::Find do let(:repo) { Repository.by_slug('svenfuchs/minimal').first } - let(:build) { repo.builds.first } + let(:build) { repo.builds.last } let(:parsed_body) { JSON.load(body) } describe "fetching builds on a public repository by slug" do @@ -26,8 +26,27 @@ describe Travis::API::V3::Services::Builds::Find do example { expect(last_response).to be_ok } example { expect(parsed_body).to be == { "@type" => "builds", - "@href" => "/v3/repo/#{repo.id}/builds", - "builds" => { + "@href" => "/v3/repo/#{repo.id}/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" =>1}, + "prev" =>nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ "@type" => "build", "@href" => "/v3/build/#{build.id}", "id" => build.id, @@ -37,6 +56,7 @@ describe Travis::API::V3::Services::Builds::Find do "event_type" => "push", "previous_state" => "passed", "started_at" => "2010-11-12T13:00:00Z", + "finished_at" => nil, "repository" => { "@type" => "repository", "@href" => "/v3/repo/1", @@ -47,7 +67,7 @@ describe Travis::API::V3::Services::Builds::Find do "@href" => "/v3/repo/1/branch/master", "name" => "master", "last_build" => { - "@href"=>"/v3/build/62" }}, + "@href"=>"/v3/build/#{build.id}" }}, "commit" => { "@type" => "commit", "id" => 5, @@ -55,303 +75,303 @@ describe Travis::API::V3::Services::Builds::Find do "ref" => "refs/heads/master", "message" => "unignore Gemfile.lock", "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", - "committed_at" => "2010-11-12T12:55:00Z"}}, + "committed_at" => "2010-11-12T12:55:00Z"}}], }} end -# -# describe "missing repository" do -# before { get("/v3/repo/999999999999999") } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "public repository, private API" do -# before { Travis.config.private_api = true } -# before { get("/v3/repo/#{repo.id}") } -# after { Travis.config.private_api = false } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, not authenticated" do -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}") } -# before { repo.update_attribute(:private, false) } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, private API, authenticated as user with access" do -# let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} -# before { Permission.create(repository: repo, user: repo.owner, pull: true) } -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# after { repo.update_attribute(:private, false) } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to be == { -# "@type" => "repository", -# "@href" => "/v3/repo/#{repo.id}", -# "@permissions" => { -# "read" => true, -# "enable" => false, -# "disable" => false, -# "create_request" => false}, -# "id" => repo.id, -# "name" => "minimal", -# "slug" => "svenfuchs/minimal", -# "description" => nil, -# "github_language" => nil, -# "active" => true, -# "private" => true, -# "owner" => { -# "@type" => "user", -# "@href" => "/v3/user/#{repo.owner_id}", -# "id" => repo.owner_id, -# "login" => "svenfuchs" }, -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build_id}", -# "id" => repo.last_build_id, -# "number" => "2", -# "state" => "passed", -# "duration" => nil, -# "started_at" => "2010-11-12T12:30:00Z", -# "finished_at" => "2010-11-12T12:30:20Z"}, -# "default_branch" => { -# "@type" => "branch", -# "@href" => "/v3/repo/#{repo.id}/branch/master", -# "name" => "master", -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build.id}", -# "id" => repo.last_build.id, -# "number" => "3", -# "state" => "configured", -# "duration" => nil, -# "event_type" => "push", -# "previous_state" => "passed", -# "started_at" => "2010-11-12T13:00:00Z", -# "finished_at" => nil}} -# }} -# end -# -# describe "private repository, private API, authenticated as user without access" do -# let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, authenticated as internal application with full access" do -# let(:app_name) { 'travis-example' } -# let(:app_secret) { '12345678' } -# let(:sign_opts) { "a=#{app_name}" } -# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} -# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} -# -# -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# -# -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to be == { -# "@type" => "repository", -# "@href" => "/v3/repo/#{repo.id}", -# "@permissions" => { -# "read" => true, -# "enable" => true, -# "disable" => true, -# "create_request" => true}, -# "id" => repo.id, -# "name" => "minimal", -# "slug" => "svenfuchs/minimal", -# "description" => nil, -# "github_language" => nil, -# "active" => true, -# "private" => true, -# "owner" => { -# "@type" => "user", -# "@href" => "/v3/user/#{repo.owner_id}", -# "id" => repo.owner_id, -# "login" => "svenfuchs" }, -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build_id}", -# "id" => repo.last_build_id, -# "number" => "2", -# "state" => "passed", -# "duration" => nil, -# "started_at" => "2010-11-12T12:30:00Z", -# "finished_at" => "2010-11-12T12:30:20Z"}, -# "default_branch" => { -# "@type" => "branch", -# "@href" => "/v3/repo/#{repo.id}/branch/master", -# "name" => "master", -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build.id}", -# "id" => repo.last_build.id, -# "number" => "3", -# "state" => "configured", -# "duration" => nil, -# "event_type" => "push", -# "previous_state" => "passed", -# "started_at" => "2010-11-12T13:00:00Z", -# "finished_at" => nil}} -# }} -# end -# -# describe "private repository, authenticated as internal application with full access, but scoped to a different org" do -# let(:app_name) { 'travis-example' } -# let(:app_secret) { '12345678' } -# let(:sign_opts) { "a=#{app_name}:s=travis-pro" } -# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} -# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} -# -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# -# example { expect(last_response).to be_not_found } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "not_found", -# "error_message" => "repository not found (or insufficient access)", -# "resource_type" => "repository" -# }} -# end -# -# describe "private repository, authenticated as internal application with full access, scoped to the right org" do -# let(:app_name) { 'travis-example' } -# let(:app_secret) { '12345678' } -# let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" } -# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } -# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} -# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} -# -# -# before { repo.update_attribute(:private, true) } -# before { get("/v3/repo/#{repo.id}", {}, headers) } -# before { repo.update_attribute(:private, false) } -# -# -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to be == { -# "@type" => "repository", -# "@href" => "/v3/repo/#{repo.id}", -# "@permissions" => { -# "read" => true, -# "enable" => true, -# "disable" => true, -# "create_request" => true}, -# "id" => repo.id, -# "name" => "minimal", -# "slug" => "svenfuchs/minimal", -# "description" => nil, -# "github_language" => nil, -# "active" => true, -# "private" => true, -# "owner" => { -# "@type" => "user", -# "@href" => "/v3/user/#{repo.owner_id}", -# "id" => repo.owner_id, -# "login" => "svenfuchs" }, -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build_id}", -# "id" => repo.last_build_id, -# "number" => "2", -# "state" => "passed", -# "duration" => nil, -# "started_at" => "2010-11-12T12:30:00Z", -# "finished_at" => "2010-11-12T12:30:20Z"}, -# "default_branch" => { -# "@type" => "branch", -# "@href" => "/v3/repo/#{repo.id}/branch/master", -# "name" => "master", -# "last_build" => { -# "@type" => "build", -# "@href" => "/v3/build/#{repo.last_build.id}", -# "id" => repo.last_build.id, -# "number" => "3", -# "state" => "configured", -# "duration" => nil, -# "event_type" => "push", -# "previous_state" => "passed", -# "started_at" => "2010-11-12T13:00:00Z", -# "finished_at" => nil}} -# }} -# end -# -# describe "including full owner" do -# before { get("/v3/repo/#{repo.id}?include=repository.owner") } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at", -# "@type" => "user", -# "id" => repo.owner_id, -# "login" => "svenfuchs", -# )} -# end -# -# describe "including full owner and full last build" do -# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build") } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body['last_build']['state']).to be == 'passed' } -# example { expect(parsed_body['last_build']['repository']).to be == { "@href" => "/v3/repo/#{repo.id}" } } -# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at")} -# end -# -# describe "including non-existing field" do -# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build_number") } -# example { expect(last_response.status).to be == 400 } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "wrong_params", -# "error_message" => "no field \"repository.last_build_number\" to include" -# }} -# end -# -# describe "wrong include format" do -# before { get("/v3/repo/#{repo.id}?include=repository.last_build.branch") } -# example { expect(last_response.status).to be == 400 } -# example { expect(parsed_body).to be == { -# "@type" => "error", -# "error_type" => "wrong_params", -# "error_message" => "illegal format for include parameter" -# }} -# end -# -# describe "including nested objects" do -# before { get("/v3/repo/#{repo.id}?include=repository.last_build,build.branch") } -# example { expect(last_response).to be_ok } -# example { expect(parsed_body).to include("last_build") } -# end + + describe "builds on missing repository" do + before { get("/v3/repo/999999999999999/builds") } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on public repository, private API" do + before { Travis.config.private_api = true } + before { get("/v3/repo/#{repo.id}/builds") } + after { Travis.config.private_api = false } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on private repository, not authenticated" do + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds") } + before { repo.update_attribute(:private, false) } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds private repository, private API, authenticated as user with access" do + let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} + before { Permission.create(repository: repo, user: repo.owner, pull: true) } + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } + after { repo.update_attribute(:private, false) } + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "builds", + "@href" => "/v3/repo/1/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" => 1 }, + "prev" => nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ + "@type" => "build", + "@href" => "/v3/build/#{build.id}", + "id" => build.id, + "number" => "3", + "state" => "configured", + "duration" => nil, + "event_type" => "push", + "previous_state" => "passed", + "started_at" => "2010-11-12T13:00:00Z", + "finished_at" =>nil, + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/1", + "id" => 1, + "slug" => "svenfuchs/minimal"}, + "branch" => { + "@type" => "branch", + "@href" => "/v3/repo/1/branch/master", + "name" => "master", + "last_build" => { + "@href" => "/v3/build/#{build.id}"}}, + "commit" => { + "@type" => "commit", + "id" => 5, + "sha" => "add057e66c3e1d59ef1f", + "ref" => "refs/heads/master", + "message" => "unignore Gemfile.lock", + "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", + "committed_at" => "2010-11-12T12:55:00Z"}}] + }} + end + + describe "builds on private repository, private API, authenticated as user without access" do + let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds", {}, headers) } + before { repo.update_attribute(:private, false) } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on private repository, authenticated as internal application with full access" do + let(:app_name) { 'travis-example' } + let(:app_secret) { '12345678' } + let(:sign_opts) { "a=#{app_name}" } + let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} + before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} + + + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } + before { repo.update_attribute(:private, false) } + + + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "builds", + "@href" => "/v3/repo/1/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" => 1 }, + "prev" => nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ + "@type" => "build", + "@href" => "/v3/build/#{build.id}", + "id" => build.id, + "number" => "3", + "state" => "configured", + "duration" => nil, + "event_type" => "push", + "previous_state" => "passed", + "started_at" => "2010-11-12T13:00:00Z", + "finished_at" =>nil, + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/1", + "id" => 1, + "slug" => "svenfuchs/minimal"}, + "branch" => { + "@type" => "branch", + "@href" => "/v3/repo/1/branch/master", + "name" => "master", + "last_build" => { + "@href" => "/v3/build/#{build.id}"}}, + "commit" => { + "@type" => "commit", + "id" => 5, + "sha" => "add057e66c3e1d59ef1f", + "ref" => "refs/heads/master", + "message" => "unignore Gemfile.lock", + "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", + "committed_at" => "2010-11-12T12:55:00Z"}}] + }} + end + + describe "builds on private repository, authenticated as internal application with full access, but scoped to a different org" do + let(:app_name) { 'travis-example' } + let(:app_secret) { '12345678' } + let(:sign_opts) { "a=#{app_name}:s=travis-pro" } + let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} + before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} + + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds", {}, headers) } + before { repo.update_attribute(:private, false) } + + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + + describe "builds on private repository, authenticated as internal application with full access, scoped to the right org" do + let(:app_name) { 'travis-example' } + let(:app_secret) { '12345678' } + let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" } + let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} + before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} + + + before { repo.update_attribute(:private, true) } + before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } + before { repo.update_attribute(:private, false) } + + + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "builds", + "@href" => "/v3/repo/1/builds?limit=1", + "@pagination" => { + "limit" => 1, + "offset" => 0, + "count" => 3, + "is_first" => true, + "is_last" => false, + "next" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "offset" => 1, + "limit" => 1 }, + "prev" => nil, + "first" => { + "@href" => "/v3/repo/1/builds?limit=1", + "offset" => 0, + "limit" => 1 }, + "last" => { + "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "offset" => 2, + "limit" => 1 }}, + "builds" => [{ + "@type" => "build", + "@href" => "/v3/build/#{build.id}", + "id" => build.id, + "number" => "3", + "state" => "configured", + "duration" => nil, + "event_type" => "push", + "previous_state" => "passed", + "started_at" => "2010-11-12T13:00:00Z", + "finished_at" =>nil, + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/1", + "id" => 1, + "slug" => "svenfuchs/minimal"}, + "branch" => { + "@type" => "branch", + "@href" => "/v3/repo/1/branch/master", + "name" => "master", + "last_build" => { + "@href" => "/v3/build/#{build.id}"}}, + "commit" => { + "@type" => "commit", + "id" => 5, + "sha" => "add057e66c3e1d59ef1f", + "ref" => "refs/heads/master", + "message" => "unignore Gemfile.lock", + "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", + "committed_at" => "2010-11-12T12:55:00Z"}}] + }} + end + + describe "including non-existing field" do + before { get("/v3/repo/#{repo.id}/builds?include=repository.owner,repository.last_build_number") } + example { expect(last_response.status).to be == 400 } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "wrong_params", + "error_message" => "no field \"repository.last_build_number\" to include" + }} + end + + describe "wrong include format" do + before { get("/v3/repo/#{repo.id}/builds?include=repository.last_build.branch") } + example { expect(last_response.status).to be == 400 } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "wrong_params", + "error_message" => "illegal format for include parameter" + }} + end end From d8ad047dc8b67eedd0a936198f345a0287482c5e Mon Sep 17 00:00:00 2001 From: carlad Date: Mon, 24 Aug 2015 17:09:40 +0200 Subject: [PATCH 6/6] v3 add test for branch.name --- spec/v3/services/builds/find_spec.rb | 263 +++------------------------ 1 file changed, 21 insertions(+), 242 deletions(-) diff --git a/spec/v3/services/builds/find_spec.rb b/spec/v3/services/builds/find_spec.rb index 71d6555f..e0816a74 100644 --- a/spec/v3/services/builds/find_spec.rb +++ b/spec/v3/services/builds/find_spec.rb @@ -34,16 +34,16 @@ describe Travis::API::V3::Services::Builds::Find do "is_first" => true, "is_last" => false, "next" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "@href" => "/v3/repo/#{repo.id}/builds?limit=1&offset=1", "offset" => 1, "limit" =>1}, "prev" =>nil, "first" => { - "@href" => "/v3/repo/1/builds?limit=1", + "@href" => "/v3/repo/#{repo.id}/builds?limit=1", "offset" => 0, "limit" => 1 }, "last" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "@href" => "/v3/repo/#{repo.id}/builds?limit=1&offset=2", "offset" => 2, "limit" => 1 }}, "builds" => [{ @@ -59,12 +59,12 @@ describe Travis::API::V3::Services::Builds::Find do "finished_at" => nil, "repository" => { "@type" => "repository", - "@href" => "/v3/repo/1", - "id" => 1, + "@href" => "/v3/repo/#{repo.id}", + "id" => repo.id, "slug"=>"svenfuchs/minimal" }, "branch" => { "@type" => "branch", - "@href" => "/v3/repo/1/branch/master", + "@href" => "/v3/repo/#{repo.id}/branch/master", "name" => "master", "last_build" => { "@href"=>"/v3/build/#{build.id}" }}, @@ -79,43 +79,6 @@ describe Travis::API::V3::Services::Builds::Find do }} end - describe "builds on missing repository" do - before { get("/v3/repo/999999999999999/builds") } - example { expect(last_response).to be_not_found } - example { expect(parsed_body).to be == { - "@type" => "error", - "error_type" => "not_found", - "error_message" => "repository not found (or insufficient access)", - "resource_type" => "repository" - }} - end - - describe "builds on public repository, private API" do - before { Travis.config.private_api = true } - before { get("/v3/repo/#{repo.id}/builds") } - after { Travis.config.private_api = false } - example { expect(last_response).to be_not_found } - example { expect(parsed_body).to be == { - "@type" => "error", - "error_type" => "not_found", - "error_message" => "repository not found (or insufficient access)", - "resource_type" => "repository" - }} - end - - describe "builds on private repository, not authenticated" do - before { repo.update_attribute(:private, true) } - before { get("/v3/repo/#{repo.id}/builds") } - before { repo.update_attribute(:private, false) } - example { expect(last_response).to be_not_found } - example { expect(parsed_body).to be == { - "@type" => "error", - "error_type" => "not_found", - "error_message" => "repository not found (or insufficient access)", - "resource_type" => "repository" - }} - end - describe "builds private repository, private API, authenticated as user with access" do let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} @@ -126,7 +89,7 @@ describe Travis::API::V3::Services::Builds::Find do example { expect(last_response).to be_ok } example { expect(parsed_body).to be == { "@type" => "builds", - "@href" => "/v3/repo/1/builds?limit=1", + "@href" => "/v3/repo/#{repo.id}/builds?limit=1", "@pagination" => { "limit" => 1, "offset" => 0, @@ -134,16 +97,16 @@ describe Travis::API::V3::Services::Builds::Find do "is_first" => true, "is_last" => false, "next" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=1", + "@href" => "/v3/repo/#{repo.id}/builds?limit=1&offset=1", "offset" => 1, "limit" => 1 }, "prev" => nil, "first" => { - "@href" => "/v3/repo/1/builds?limit=1", + "@href" => "/v3/repo/#{repo.id}/builds?limit=1", "offset" => 0, "limit" => 1 }, "last" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=2", + "@href" => "/v3/repo/#{repo.id}/builds?limit=1&offset=2", "offset" => 2, "limit" => 1 }}, "builds" => [{ @@ -159,12 +122,12 @@ describe Travis::API::V3::Services::Builds::Find do "finished_at" =>nil, "repository" => { "@type" => "repository", - "@href" => "/v3/repo/1", - "id" => 1, + "@href" => "/v3/repo/#{repo.id}", + "id" => repo.id, "slug" => "svenfuchs/minimal"}, "branch" => { "@type" => "branch", - "@href" => "/v3/repo/1/branch/master", + "@href" => "/v3/repo/#{repo.id}/branch/master", "name" => "master", "last_build" => { "@href" => "/v3/build/#{build.id}"}}, @@ -179,199 +142,15 @@ describe Travis::API::V3::Services::Builds::Find do }} end - describe "builds on private repository, private API, authenticated as user without access" do - let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) } - let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} - before { repo.update_attribute(:private, true) } - before { get("/v3/repo/#{repo.id}/builds", {}, headers) } - before { repo.update_attribute(:private, false) } - example { expect(last_response).to be_not_found } - example { expect(parsed_body).to be == { - "@type" => "error", - "error_type" => "not_found", - "error_message" => "repository not found (or insufficient access)", - "resource_type" => "repository" - }} + describe "including branch.name params on existing branch" do + before { get("/v3/repo/#{repo.id}/builds?branch.name=master&limit=1") } + example { expect(last_response).to be_ok } + example { expect(parsed_body['builds'].first['branch']['name']).to be == ("master") } end - describe "builds on private repository, authenticated as internal application with full access" do - let(:app_name) { 'travis-example' } - let(:app_secret) { '12345678' } - let(:sign_opts) { "a=#{app_name}" } - let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } - let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} - before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} - - - before { repo.update_attribute(:private, true) } - before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } - before { repo.update_attribute(:private, false) } - - - example { expect(last_response).to be_ok } - example { expect(parsed_body).to be == { - "@type" => "builds", - "@href" => "/v3/repo/1/builds?limit=1", - "@pagination" => { - "limit" => 1, - "offset" => 0, - "count" => 3, - "is_first" => true, - "is_last" => false, - "next" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=1", - "offset" => 1, - "limit" => 1 }, - "prev" => nil, - "first" => { - "@href" => "/v3/repo/1/builds?limit=1", - "offset" => 0, - "limit" => 1 }, - "last" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=2", - "offset" => 2, - "limit" => 1 }}, - "builds" => [{ - "@type" => "build", - "@href" => "/v3/build/#{build.id}", - "id" => build.id, - "number" => "3", - "state" => "configured", - "duration" => nil, - "event_type" => "push", - "previous_state" => "passed", - "started_at" => "2010-11-12T13:00:00Z", - "finished_at" =>nil, - "repository" => { - "@type" => "repository", - "@href" => "/v3/repo/1", - "id" => 1, - "slug" => "svenfuchs/minimal"}, - "branch" => { - "@type" => "branch", - "@href" => "/v3/repo/1/branch/master", - "name" => "master", - "last_build" => { - "@href" => "/v3/build/#{build.id}"}}, - "commit" => { - "@type" => "commit", - "id" => 5, - "sha" => "add057e66c3e1d59ef1f", - "ref" => "refs/heads/master", - "message" => "unignore Gemfile.lock", - "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", - "committed_at" => "2010-11-12T12:55:00Z"}}] - }} - end - - describe "builds on private repository, authenticated as internal application with full access, but scoped to a different org" do - let(:app_name) { 'travis-example' } - let(:app_secret) { '12345678' } - let(:sign_opts) { "a=#{app_name}:s=travis-pro" } - let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } - let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} - before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} - - before { repo.update_attribute(:private, true) } - before { get("/v3/repo/#{repo.id}/builds", {}, headers) } - before { repo.update_attribute(:private, false) } - - example { expect(last_response).to be_not_found } - example { expect(parsed_body).to be == { - "@type" => "error", - "error_type" => "not_found", - "error_message" => "repository not found (or insufficient access)", - "resource_type" => "repository" - }} - end - - describe "builds on private repository, authenticated as internal application with full access, scoped to the right org" do - let(:app_name) { 'travis-example' } - let(:app_secret) { '12345678' } - let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" } - let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } - let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} - before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} - - - before { repo.update_attribute(:private, true) } - before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) } - before { repo.update_attribute(:private, false) } - - - example { expect(last_response).to be_ok } - example { expect(parsed_body).to be == { - "@type" => "builds", - "@href" => "/v3/repo/1/builds?limit=1", - "@pagination" => { - "limit" => 1, - "offset" => 0, - "count" => 3, - "is_first" => true, - "is_last" => false, - "next" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=1", - "offset" => 1, - "limit" => 1 }, - "prev" => nil, - "first" => { - "@href" => "/v3/repo/1/builds?limit=1", - "offset" => 0, - "limit" => 1 }, - "last" => { - "@href" => "/v3/repo/1/builds?limit=1&offset=2", - "offset" => 2, - "limit" => 1 }}, - "builds" => [{ - "@type" => "build", - "@href" => "/v3/build/#{build.id}", - "id" => build.id, - "number" => "3", - "state" => "configured", - "duration" => nil, - "event_type" => "push", - "previous_state" => "passed", - "started_at" => "2010-11-12T13:00:00Z", - "finished_at" =>nil, - "repository" => { - "@type" => "repository", - "@href" => "/v3/repo/1", - "id" => 1, - "slug" => "svenfuchs/minimal"}, - "branch" => { - "@type" => "branch", - "@href" => "/v3/repo/1/branch/master", - "name" => "master", - "last_build" => { - "@href" => "/v3/build/#{build.id}"}}, - "commit" => { - "@type" => "commit", - "id" => 5, - "sha" => "add057e66c3e1d59ef1f", - "ref" => "refs/heads/master", - "message" => "unignore Gemfile.lock", - "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", - "committed_at" => "2010-11-12T12:55:00Z"}}] - }} - end - - describe "including non-existing field" do - before { get("/v3/repo/#{repo.id}/builds?include=repository.owner,repository.last_build_number") } - example { expect(last_response.status).to be == 400 } - example { expect(parsed_body).to be == { - "@type" => "error", - "error_type" => "wrong_params", - "error_message" => "no field \"repository.last_build_number\" to include" - }} - end - - describe "wrong include format" do - before { get("/v3/repo/#{repo.id}/builds?include=repository.last_build.branch") } - example { expect(last_response.status).to be == 400 } - example { expect(parsed_body).to be == { - "@type" => "error", - "error_type" => "wrong_params", - "error_message" => "illegal format for include parameter" - }} + describe "including branch.name params on non-existing branch" do + before { get("/v3/repo/#{repo.id}/builds?branch.name=missing&limit=1") } + example { expect(last_response).to be_ok } + example { expect(parsed_body['builds']).to be == [] } end end