refactor buildcancellation worker

.gitignore

@@ -3,3 +3,4 @@ config/travis.yml
 log/
 vendor
 config/skylight.yml
+.coverage

lib/travis/api/app/endpoint/builds.rb

@@ -1,4 +1,5 @@
 require 'travis/api/app'
+require 'travis/api/workers/build_cancellation'
 
 class Travis::Api::App
   class Endpoint
@@ -39,7 +40,7 @@ class Travis::Api::App
         else
           #service.run
           #check syntax of line below
-          Travis::Sidekiq::BuildCancellation.perform_async(params.merge(source: 'api'))
+          Travis::Sidekiq::BuildCancellation.perform_async(id: params[:id], source: 'api')
 
           Metriks.meter("api.request.cancel_build.success").mark
           status 204

lib/travis/api/workers/build_cancellation.rb

@@ -7,22 +7,10 @@ module Travis
       class ProcessingError < StandardError; end
 
       include ::Sidekiq::Worker
-      # do we need to name the queue here? we didn't do this in Admin. We passed this info in the procfile
+      sidekiq_options queue: :build_cancellations
-      sidekiq_options queue: build_cancellations
-
-      attr_accessor :data
 
       def perform(data)
-        @data = data
+        Travis.service(:cancel_build, data).run
-        if payload
-          service.run
-        else
-          Travis.logger.warn("The #{type} payload was empty and could not be processed")
-        end
-      end
-
-      def service
-        @service ||= Travis.service(:cancel_build, data)
       end
     end
   end

spec/integration/v2/builds_spec.rb

@@ -75,17 +75,20 @@ describe 'Builds' do
     end
 
     context 'when build can be canceled' do
-      it 'cancels the build and responds with 204' do
+      before do
+        Travis::Sidekiq::BuildCancellation.stubs(:perform_async)
         build.matrix.each { |j| j.update_attribute(:state, 'created') }
         build.update_attribute(:state, 'created')
+      end
 
-        response = nil
+      it 'cancels the build' do
-        expect {
+        Travis::Sidekiq::BuildCancellation.expects(:perform_async).with(id: build.id.to_s, source: 'api')
+        post "/builds/#{build.id}/cancel", {}, headers
+      end
+
+      it 'responds with 204' do
         response = post "/builds/#{build.id}/cancel", {}, headers
-        }.to change { build.reload.state }
         response.status.should == 204
-
-        build.state.should == 'canceled'
       end
     end
   end