suzanne.soy/travis-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use document.createElement('iframe') instad of document.write

Browse Source
This commit is contained in:
Piotr Sarnacki 2012-11-18 14:47:53 +01:00
parent 07d965307f
commit a787f32e52
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/travis/api/app/endpoint/authorization.rb
View File

@ -270,7 +270,6 @@ alert('refusing to send a token to <%= target_origin.inspect %>, not whitelisted
img.src = "https://third-party-cookies.herokuapp.com/set"; img.src = "https://third-party-cookies.herokuapp.com/set";
img.onload = function() { img.onload = function() {
console.log('img onload');
var script = document.createElement('script'); var script = document.createElement('script');
script.src = "https://third-party-cookies.herokuapp.com/check"; script.src = "https://third-party-cookies.herokuapp.com/check";
window.document.body.appendChild(script); window.document.body.appendChild(script);
@ -280,7 +279,9 @@ alert('refusing to send a token to <%= target_origin.inspect %>, not whitelisted
function cookiesCheckCallback(thirdPartyCookiesEnabled) { function cookiesCheckCallback(thirdPartyCookiesEnabled) {
if(thirdPartyCookiesEnabled) { if(thirdPartyCookiesEnabled) {
document.write('<iframe src="'+url+'" />'); var iframe = document.createElement('iframe');
iframe.src = url;
window.document.body.appendChild(iframe);
} else { } else {
window.open(url, 'Signing in...', 'height=400,width=800'); window.open(url, 'Signing in...', 'height=400,width=800');
} }