From ac106488c705202630eb4a2d142160e34f1774dd Mon Sep 17 00:00:00 2001 From: Hiro Asari Date: Sun, 1 Dec 2013 20:44:39 -0500 Subject: [PATCH] Eschew questionable use of `File.join` For constructing a URL, `File.join` is inappropriate. --- lib/travis/api/app/responders/xml.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/travis/api/app/responders/xml.rb b/lib/travis/api/app/responders/xml.rb index 26534513..25b8b62c 100644 --- a/lib/travis/api/app/responders/xml.rb +++ b/lib/travis/api/app/responders/xml.rb @@ -13,7 +13,7 @@ module Travis::Api::App::Responders lastBuildStatus="<%= STATUS[r.last_build.state.to_sym] || STATUS[:default] %>" lastBuildLabel="<%= r.last_build.try(:number) %>" lastBuildTime="<%= r.last_build.finished_at.try(:strftime, '%Y-%m-%dT%H:%M:%S.%L%z') %>" - webUrl="<%= File.join("https://", Travis.config.client_domain, r.slug) %>" /> + webUrl="https://<%= Travis.config.client_domain %>/<%= r.slug %>" <% end %> EOF