suzanne.soy/travis-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Convert params['ids'] to array

Browse Source 
Services like find_builds can accept :ids as a param, but it needs to be
an array, string will be passed to find and converted into integer.
This commit is contained in:
Piotr Sarnacki 2013-07-09 15:14:53 +02:00
parent 40430ac34d
commit b6a351c766
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/travis/api/app/endpoint/builds.rb
View File

@ -5,6 +5,7 @@ class Travis::Api::App
class Builds < Endpoint class Builds < Endpoint
get '/' do get '/' do
name = params[:branches] ? :find_branches : :find_builds name = params[:branches] ? :find_branches : :find_builds
params['ids'] = params['ids'].split(',') if params['ids'].respond_to?(:split)
respond_with service(name, params) respond_with service(name, params)
end end

2
lib/travis/api/app/endpoint/repos.rb
View File

@ -63,6 +63,8 @@ class Travis::Api::App
# #
# json(:builds) # json(:builds)
get '/:owner_name/:name/builds' do get '/:owner_name/:name/builds' do
name = params[:branches] ? :find_branches : :find_builds
params['ids'] = params['ids'].split(',') if params['ids'].respond_to?(:split)
respond_with service(:find_builds, params) respond_with service(:find_builds, params)
end end

12
spec/integration/v2/builds_spec.rb
View File

@ -25,6 +25,18 @@ describe 'Builds' do
response.should deliver_json_for(repo.builds.order('id DESC'), version: 'v2', type: :builds) response.should deliver_json_for(repo.builds.order('id DESC'), version: 'v2', type: :builds)
end end
it 'GET /repos/svenfuchs/minimal/builds?ids=1,2' do
ids = repo.builds.map(&:id).sort.join(',')
response = get "/repos/svenfuchs/minimal/builds?ids=#{ids}", {}, headers
response.should deliver_json_for(repo.builds.order('id ASC'), version: 'v2')
end
it 'GET /builds?ids=1,2' do
ids = repo.builds.map(&:id).sort.join(',')
response = get "/builds?ids=#{ids}", {}, headers
response.should deliver_json_for(repo.builds.order('id ASC'), version: 'v2')
end
it 'GET /repos/svenfuchs/minimal/builds/1' do it 'GET /repos/svenfuchs/minimal/builds/1' do
response = get "/repos/svenfuchs/minimal/builds/#{build.id}", {}, headers response = get "/repos/svenfuchs/minimal/builds/#{build.id}", {}, headers
response.should deliver_json_for(build, version: 'v2') response.should deliver_json_for(build, version: 'v2')